Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SnippetTextEdit in code actions #3730

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Add support for SnippetTextEdit in code actions #3730

merged 4 commits into from
Sep 3, 2024

Conversation

hopehadfield
Copy link
Contributor

@hopehadfield hopehadfield mentioned this pull request Jul 31, 2024
Merged
@hopehadfield hopehadfield force-pushed the 3686-linked-proposals branch 2 times, most recently from a95f695 to 00abea2 Compare July 31, 2024 18:59
@hopehadfield hopehadfield force-pushed the 3686-linked-proposals branch from 866d26a to 8e6007c Compare August 12, 2024 20:43
rgrunber
rgrunber reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small fixes.

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
rgrunber
rgrunber reviewed Aug 16, 2024
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
rgrunber
rgrunber approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client-side code here looks good, and is ready to be merged once the LS side is in.

@hopehadfield hopehadfield force-pushed the 3686-linked-proposals branch from 3437c83 to a8d96b9 Compare August 20, 2024 17:59
@hopehadfield hopehadfield force-pushed the 3686-linked-proposals branch from a8d96b9 to ea02c98 Compare August 20, 2024 18:47
@rgrunber
Copy link
Member

Random fact learned : CodeAction.set(Uri, null) will clear the edits for a particular Uri but a non-null 2nd argument will merely append. See microsoft/vscode#197315

@rgrunber rgrunber merged commit 1d7163f into redhat-developer:master Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support linked correction proposals
2 participants
@hopehadfield @rgrunber