Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4425 add additional tag based filtering in helm UI page #4525

Conversation

msivasubramaniaan
Copy link
Collaborator

Ref: #4425
helm-filter-treeView

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.42%. Comparing base (da60441) to head (e22ec83).
Report is 569 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4525       +/-   ##
===========================================
+ Coverage   32.37%   43.42%   +11.04%     
===========================================
  Files          85       98       +13     
  Lines        6505     8049     +1544     
  Branches     1349     1713      +364     
===========================================
+ Hits         2106     3495     +1389     
- Misses       4399     4554      +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change to simplify the code, but otherwise looks good and works well

src/webview/helm-chart/app/helmSearch.tsx Outdated Show resolved Hide resolved
Signed-off-by: msivasubramaniaan <[email protected]>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks, Muthu!

@datho7561 datho7561 merged commit 46ba3c2 into redhat-developer:main Oct 4, 2024
4 checks passed
@msivasubramaniaan msivasubramaniaan deleted the 4425-add-additional-tag-based-filtering-in-helm-ui-page branch October 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional tag based filtering in helm UI Page
3 participants