Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh version updated #1027

Merged
merged 5 commits into from
Jun 3, 2024
Merged

gh version updated #1027

merged 5 commits into from
Jun 3, 2024

Conversation

msivasubramaniaan
Copy link
Contributor

What does this PR do?

updated GH action version

@msivasubramaniaan msivasubramaniaan self-assigned this May 30, 2024
@datho7561
Copy link
Contributor

Try these dependency version updates:

diff --git a/package.json b/package.json
index f5f9eb0..0fead2c 100644
--- a/package.json
+++ b/package.json
@@ -263,13 +263,14 @@
     "@types/sinon-chai": "^3.2.5",
     "@types/vscode": "^1.63.0",
     "@types/webpack": "^4.4.10",
-    "@typescript-eslint/eslint-plugin": "^4.16.1",
-    "@typescript-eslint/parser": "^4.16.1",
+    "@typescript-eslint/eslint-plugin": "^7.11.0",
+    "@typescript-eslint/parser": "^7.11.0",
+    "@vscode/test-electron": "^2.4.0",
     "@vscode/test-web": "0.0.11",
     "buffer": "^6.0.3",
     "chai": "^4.2.0",
     "crypto-browserify": "^3.12.0",
-    "eslint": "^7.6.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-plugin-prettier": "^3.1.4",
     "glob": "^7.1.6",
@@ -282,12 +283,11 @@
     "sinon-chai": "^3.7.0",
     "ts-loader": "^9.2.5",
     "ts-node": "^3.3.0",
-    "typescript": "4.4.3",
+    "typescript": "^5.4.5",
     "umd-compat-loader": "^2.1.2",
     "url": "^0.11.0",
     "util": "^0.12.5",
     "vscode-extension-tester": "^5.3.0",
-    "vscode-test": "^1.4.0",
     "webpack": "^5.76.1",
     "webpack-cli": "^5.0.1"
   },

then you'll also need to update the test suite to reference the new package name:

diff --git a/test/testRunner.ts b/test/testRunner.ts
index d96f55a..93ff830 100644
--- a/test/testRunner.ts
+++ b/test/testRunner.ts
@@ -4,7 +4,7 @@
  * ------------------------------------------------------------------------------------------ */
 import * as path from 'path';
 import * as cp from 'child_process';
-import { runTests, downloadAndUnzipVSCode, resolveCliPathFromVSCodeExecutablePath } from 'vscode-test';
+import { runTests, downloadAndUnzipVSCode, resolveCliPathFromVSCodeExecutablePath } from '@vscode/test-electron';

 async function main(): Promise<void> {
   try {

After this, if I run yarn test, then I get only 1 failing test. However, this failure is because the format of the hover documentation has changed, so we will need to update the test in order to get it to pass.

@msivasubramaniaan msivasubramaniaan merged commit 604c8e7 into main Jun 3, 2024
3 checks passed
@msivasubramaniaan msivasubramaniaan deleted the upgrade-github-action-versions branch June 3, 2024 16:05
@msivasubramaniaan msivasubramaniaan mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants