Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Support Multiple Custom Kubernetes Versions and CRDs" #1028

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Revert "Support Multiple Custom Kubernetes Versions and CRDs" #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,6 @@
"default": [],
"description": "Custom tags for the parser to use"
},
"yaml.kubernetesSchemaURLs": {
"type": "array",
"default": [],
"description": "URLs to Kubernetes schemas"
},
"yaml.schemaStore.enable": {
"type": "boolean",
"default": true,
Expand Down
11 changes: 0 additions & 11 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,6 @@ namespace DynamicCustomSchemaRequestRegistration {
export const type: NotificationType<{}> = new NotificationType('yaml/registerCustomSchemaRequest');
}

// eslint-disable-next-line @typescript-eslint/no-namespace
export namespace KubernetesSchemaURLsNotification {
// eslint-disable-next-line @typescript-eslint/ban-types
export const type: NotificationType<string[]> = new NotificationType('yaml/kubernetesSchemaURLs');
}

// eslint-disable-next-line @typescript-eslint/no-namespace
namespace ResultLimitReachedNotification {
// eslint-disable-next-line @typescript-eslint/ban-types
Expand Down Expand Up @@ -167,7 +161,6 @@ export function startClient(
client.sendNotification(SchemaAssociationNotification.type, getSchemaAssociations());
findConflicts();
});
client.sendNotification(KubernetesSchemaURLsNotification.type, getKubernetesSchemaURLs());
// Tell the server that the client is ready to provide custom schema content
client.sendNotification(DynamicCustomSchemaRequestRegistration.type);
// Tell the server that the client supports schema requests sent directly to it
Expand Down Expand Up @@ -236,10 +229,6 @@ function findConflicts(): void {
}
}

function getKubernetesSchemaURLs(): string[] {
return workspace.getConfiguration('yaml').get('kubernetesSchemaURLs') || [];
}

function getSchemaAssociations(): ISchemaAssociation[] {
const associations: ISchemaAssociation[] = [];
extensions.all.forEach((extension) => {
Expand Down
Loading