fix: suggest hyphen in array

[p-spacek]

What does this PR do?

1. - (array item) suggestion was missing for some specific situations, for example: enums.
   it worked ok for 1st item after a colon, but not for 2nd

after fix:

UPDATE
I extended this PR because there were related issues, with a tiny update of this original problem, I can fix another 2 problems:
2) auto add - when hyphen is missing

choose item will produce incorrect yaml

3. The default snippet with a simple string will produce this weird result when the string value is defined in snippet body

What issues does this PR fix or reference?

no ref

Is it tested? How?

modified existing
added one test for the enum

• check for - array items
• check for -
  added test for default snippets with string value in the body property

[p-spacek]

there should be '- Test' insert text, but it's another problem

[gorkem]

Can you file that as an issue?

[p-spacek]

I fixed it in this PR the end...

[p-spacek]

unify the code for both scenarios. If a schema contains items it's an array. No need to check if type === 'object'

[p-spacek]

Hello @msivasubramaniaan, can I ask you for a review?

[gorkem]

LGTM.

Needs to be rebased before I can merge and the failing CI (which looks like a GH problem) should clear with the rebase.

Another level of improvement to this PR would be to filter the items that are already on the array to avoid duplicate entries on the array. Approving this PR but please let me know if you are planning to add the improvement.

[p-spacek]

@gorkem , I don't think that there should be such a filter/condition
because schema

{
          type: 'object',
          properties: {
            references: {
              type: 'array',
              items: {
                enum: ['Test', 'Test2'],
              },
            },
}

doesn't define that items of the array have to be unique. To be honest I am not sure how to define this (unique array items)...

This should be allowed based on the schema

items:
 - Test1
 - Test1
 - Test2

or don't you agree? did I understand you incorrectly?

[p-spacek]

I found another related problem
So I converted this PR to a draft
I'll try to fix it at once

[coveralls]

coverage: 83.841% (+0.03%) from 83.813% when pulling 8e4d05f on jigx-com:fix/suggest-hyphen-in-arrays into ed03cbf on redhat-developer:main.

[gorkem]

Correct, item uniqueness is determined by the schema. The current implementation does not take into account the uniqueItems flag. An improvement to the current implementation would be checking this flag and filtering accordingly. In general, code assist should not suggest values leading to syntax errors, even though it is a trivial fix.