Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-46532: clean data while collecting result archive #128

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Dec 17, 2024

OCPBUGS-46532

Plugin ref https://issues.redhat.com/browse/OCPBUGS-46369
redhat-openshift-ecosystem/provider-certification-plugins#68

This PR introduce a cleaner engine to remove predefined, unexpected, data from artifacts on client side to prevent exposing it to shareable/public artifacts.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@mtulio
Copy link
Contributor Author

mtulio commented Dec 17, 2024

/assign @rvanderp3

@mtulio mtulio changed the title OCPBUGS-46369: cleaning patterns while downloading report file OCPBUGS-46532: cleaning patterns while downloading report file Dec 17, 2024
@mtulio mtulio marked this pull request as ready for review December 17, 2024 21:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@mtulio mtulio marked this pull request as draft December 17, 2024 21:47
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@mtulio
Copy link
Contributor Author

mtulio commented Dec 17, 2024

I will test in a live cluster before moving to ready to review

@mtulio mtulio force-pushed the OCPBUGS-46369 branch 2 times, most recently from 0435e3f to 2bd0de0 Compare December 18, 2024 03:35
@mtulio
Copy link
Contributor Author

mtulio commented Dec 18, 2024

@mtulio mtulio marked this pull request as ready for review December 18, 2024 03:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@openshift-ci openshift-ci bot requested a review from rvanderp3 December 18, 2024 03:56
@mtulio mtulio added the kind/bug Categorizes issue or PR as related to a bug. label Dec 18, 2024
@mtulio mtulio changed the title OCPBUGS-46532: cleaning patterns while downloading report file OCPBUGS-46532: clean unexpected data exposed while collecting results Dec 18, 2024
@mtulio mtulio changed the title OCPBUGS-46532: clean unexpected data exposed while collecting results OCPBUGS-46532: clean unexpected data while collecting results Dec 18, 2024
@mtulio mtulio changed the title OCPBUGS-46532: clean unexpected data while collecting results OCPBUGS-46532: clean data while collecting result archive Dec 18, 2024
@mtulio mtulio force-pushed the OCPBUGS-46369 branch 5 times, most recently from 4f214dc to 598d613 Compare December 20, 2024 02:22
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2024
@mtulio mtulio added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 28, 2024
@rvanderp3
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2024
Copy link

openshift-ci bot commented Dec 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2024
Introduce predefined cleaner to remove sensitive data from files
collected by opct/sonobuoy and eventually is exposing the deta from
non-standard format (secrets).
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2024
Copy link

openshift-ci bot commented Dec 29, 2024

New changes are detected. LGTM label has been removed.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 29, 2024

Rebased, required labels have been cleaned after rebase commit. I will merge manually once the e2e are passing.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 29, 2024

/lgtm /approve

e2e passing, merging to create a release v0.5.1 with #132

@mtulio mtulio merged commit 09fb349 into redhat-openshift-ecosystem:main Dec 29, 2024
15 of 16 checks passed
@mtulio mtulio deleted the OCPBUGS-46369 branch December 29, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. target-release/opct-v0.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants