-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46532: clean data while collecting result archive #128
Conversation
8c94a55
to
8d992a7
Compare
/assign @rvanderp3 |
I will test in a live cluster before moving to ready to review |
0435e3f
to
2bd0de0
Compare
We are good to go, tests taken and documented here: https://issues.redhat.com/browse/OCPBUGS-46532?focusedId=26298632&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-26298632 /assign @rvanderp3 |
2bd0de0
to
78059f5
Compare
4f214dc
to
598d613
Compare
471cfae
to
fbe1127
Compare
fbe1127
to
7fe32fd
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introduce predefined cleaner to remove sensitive data from files collected by opct/sonobuoy and eventually is exposing the deta from non-standard format (secrets).
7fe32fd
to
96af35d
Compare
New changes are detected. LGTM label has been removed. |
Rebased, required labels have been cleaned after rebase commit. I will merge manually once the e2e are passing. |
e2e passing, merging to create a release v0.5.1 with #132 |
09fb349
into
redhat-openshift-ecosystem:main
OCPBUGS-46532
Plugin ref https://issues.redhat.com/browse/OCPBUGS-46369
redhat-openshift-ecosystem/provider-certification-plugins#68
This PR introduce a cleaner engine to remove predefined, unexpected, data from artifacts on client side to prevent exposing it to shareable/public artifacts.