Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/controller-runtime from 0.15.0 to 0.16.0 #1053

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2023

Bumps sigs.k8s.io/controller-runtime from 0.15.0 to 0.16.0.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.16.0

Highlights

  • Granular cache configuration (#2421)
  • New cache option to fail on missing informer on cache reads (#2406)
  • Secure metrics serving (#2407)
  • Upgrade to Kubernetes 1.28 libraries (#2393, #2405, #2449)

Changes since v0.15

⚠️ Breaking Changes

✨ New Features

🐛 Bug Fixes

🌱 Others

... (truncated)

Commits
  • c20ea14 ✨ Allow non-blocking retrieval of informers (#2371)
  • 304027b Merge pull request #2451 from sbueringer/pr-log-warn
  • f4735b6 log warning if error and non-zero Result returned
  • 480fc5b Merge pull request #2450 from sbueringer/pr-bump-ct-v0.13
  • 96854e7 Bump to controller-tools v0.13
  • f30e11d pkg/{cache,client}: add options for cache miss policy (#2406)
  • d781099 Merge pull request #2449 from sbueringer/pr-bump-k8s-1.28
  • 2291e7d Bump to k8s.io v1.28.0
  • 6d99b58 Merge pull request #2433 from lleshchi/issue_2429
  • 8a1ef8b Merge pull request #2446 from kubernetes-sigs/dependabot/go_modules/gomodules...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.15.0 to 0.16.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign jomkz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acornett21
Copy link
Contributor

It seems this is blocked bc of a dependency on chart-verifier, which has mismatch versions, even if that is updated still not sure this will work.

@komish
Copy link
Contributor

komish commented Aug 29, 2023

Chart Verifier and Preflight are both blocked because https://github.com/operator-framework/api hasn't moved to using 0.28.0 of these libraries, as this PR would.

The otel/metric/instrument library was deprecated in otel's v1.15.1 release (https://github.com/open-telemetry/opentelemetry-go/blob/v1.15.1/metric/instrument/deprecation.go#L18)

The bump to 0.28.0 of k8s.io libraries seems to use otel 1.17.0 which has fully removed this package, so by trying to bump this, we cannot build.

We need operator-framework to bump before we can bump these versions.

@acornett21
Copy link
Contributor

Even if operator-sdk and chart-verifier are updated, this leads to other issues, so I'm not sure if we'll ever be in a world where dependency issues are not a problem. I think even going to the pluggable model, that this will get worse, and much more of a frustration to deal with.

@acornett21
Copy link
Contributor

@dependabot close

@acornett21 acornett21 closed this Aug 31, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.16.0 branch August 31, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants