Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVP-3985] Add spec.skips to parsed_operator_data #457

Conversation

yashvardhannanavati
Copy link
Collaborator

No description provided.

@yashvardhannanavati yashvardhannanavati force-pushed the olm_variables branch 5 times, most recently from ce6e78f to b2e931f Compare February 9, 2024 22:04
@yashvardhannanavati
Copy link
Collaborator Author

@asergienk @nmars @samvarankashyap Could you please help take a look?

P.S: The CI seems to be failing on something unrelated to this change. Please correct me if I am mistaken

@yashvardhannanavati yashvardhannanavati force-pushed the olm_variables branch 2 times, most recently from 8dba594 to 4261da7 Compare February 12, 2024 05:19
@lslebodn
Copy link

@asergienk @nmars @samvarankashyap Could you please help take a look?

pyxis just return different error message. it shodul eb trivial to fix it in the same PR but different commit message

@yashvardhannanavati
Copy link
Collaborator Author

@asergienk @nmars @samvarankashyap Could you please help take a look?

pyxis just return different error message. it shodul eb trivial to fix it in the same PR but different commit message

fixed it in #459

@nmars
Copy link
Contributor

nmars commented Feb 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@yashvardhannanavati yashvardhannanavati merged commit b183487 into redhat-openshift-ecosystem:master Feb 13, 2024
3 checks passed
@yashvardhannanavati yashvardhannanavati deleted the olm_variables branch February 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants