Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updates for next release of preflight-trigger #60

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mrhillsman
Copy link
Collaborator

@mrhillsman mrhillsman commented Dec 13, 2024

Changes

  • Upgrade to go1.23
  • Upgrade golangci lint to v1.62.2
  • Ignore content irrelevant for image build
  • Potential testing documentation
  • Force JobSuffix value to be claim
  • Resolve linting error

Signed-off-by: Melvin Hillsman <[email protected]>
Signed-off-by: Melvin Hillsman <[email protected]>
Signed-off-by: Melvin Hillsman <[email protected]>
@openshift-ci openshift-ci bot requested review from bcrochet and komish December 13, 2024 20:24
@mrhillsman mrhillsman changed the title next Outstanding updates Dec 13, 2024
@mrhillsman mrhillsman changed the title Outstanding updates [WIP] Updates for next release of preflight-trigger Dec 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
We no longer build clusters when they are not available to be claimed.
The proper way to get a cluster for a job when the cluster version is
not available is to temporarily add the version to be created for
claims from a pool.

Signed-off-by: Melvin Hillsman <[email protected]>
internal/errors.go:11:21  govet  printf: non-constant format string in call to fmt.Sprintf

Signed-off-by: Melvin Hillsman <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants