Skip to content

Commit

Permalink
OPCT-257: fixes/ci pipeline to publish multi-arch manifests (#59) (#61)
Browse files Browse the repository at this point in the history
> This is a backport patching and fixing the release pipeline applied on
branch `release-v0.5` (#59). It should be merged to `main` to feed the
#57

CI pipeline is crashing when publishing a tag using an old build method.

This syncronizes to main the fixes applied in `release-0.5` branch (and
tag
[v0.5.0-alpha.4](https://github.com/redhat-openshift-ecosystem/provider-certification-plugins/releases/tag/v0.5.0-alpha.4)):
- missing dependencies from #51 by calling the new multi-arch build
scripts.
- unsupported step for docker login in Pull Requests from forks
(external pushes)
- fix push expiration for PR builds on local branches.
  • Loading branch information
mtulio authored Jul 22, 2024
1 parent 4bfcfce commit 9217d7b
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

# Skip login step when the PR is from external repo, where
# Secrets isnt exported.
- name: Login to Docker Hub
if: github.event.pull_request.head.repo.full_name == github.repository
uses: docker/login-action@v3
with:
registry: quay.io
Expand Down Expand Up @@ -144,8 +147,8 @@ jobs:
needs: [build-container-amd64]
env:
PLATFORMS: linux/amd64,linux/arm64
EXPIRATION: 1d
PUSH: false
EXPIRATION: never
PUSH: true
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down

0 comments on commit 9217d7b

Please sign in to comment.