Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkgs and add missing #54

Conversation

jcpowermac
Copy link

Update oc to stable-4.14

openshift-tests are missing some tools
such as diff and git. The tests
image also has python3-six

Update `oc` to stable-4.14

openshift-tests are missing some tools
such as `diff` and `git`. The tests
image also has python3-six
@openshift-ci openshift-ci bot requested review from mtulio and rvanderp3 February 29, 2024 21:17
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Author

this needs testing

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio
Copy link
Contributor

mtulio commented Aug 9, 2024

Hi @jcpowermac , reviewing this change, looks like the most recent plugin refact, changing the plugin architecture by running openshift-tests inside it's own container provided by payload may resolve this issue by removing the needed to install diff and git.

I can't see anymore the failures in kubernetes/conformance running the v0.5+. Do you think we can close this one?

@mtulio
Copy link
Contributor

mtulio commented Jan 2, 2025

Plugin architecture changes, incorporated in v0.5+, re-using the shipped openshift-tests image as a sidecar container preventing incorporating openshift-tests requirements on OPCT plugins images. Closing this as obsolete.

@mtulio mtulio closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants