Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lbaasv2 #343

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Lbaasv2 #343

wants to merge 6 commits into from

Conversation

bartpved
Copy link

@bartpved bartpved commented May 7, 2017

Hi guys,
This pull request is related to #340
We (Tieto Tecong folks) forked the repo, and did some modifications.
At this moment running OpenShift at our dev env requires quite amount of tuning (done in our fork),
so this pull request is not tested -> it contains only the lbaasv2 fucntionality.
But still it may be good enough as a starting point.

Let's see how to work on from here, in case you are interested in this feature.
We have also other smaller features and fixes, so maybe we could propose further pull requests.
In ideal case, we would want to have all out modifications upstream.

-Vedran (on behalf of the tecong team)

@bartpved
Copy link
Author

bartpved commented May 8, 2017

Should I make a new pull request to a new feature branch, instead of the master?

@ioggstream
Copy link
Contributor

@bartpved thx++! I implemented a different solution adding a PoolMember in every master in master.yaml. I saw you used %index%. Your solution seems cool as you didn't modify master.yaml

@bartpved
Copy link
Author

bartpved commented May 9, 2017

cheers! :-)

@ioggstream
Copy link
Contributor

@bartpved I just added update_dns support for LBaaS. Check #330. Feedback welcome!

@ioggstream
Copy link
Contributor

@bartpved I'm adding a lbaas configuration for the wildcard domain too (balancing nodes). Would you do it in the same lbaas.yaml or in a different one?

@cwpenhale
Copy link

Hi Gang,

Still working on getting this deployed on my Openstack deployment, but somethings I noticed when deploying:

  1. ERROR: The Parameter (external_network_subnet) was not defined in template.
  2. ERROR: The Parameter (os_domain_name) was not defined in template.

I was able to get the stack to create by adding those parameters to openstack.yaml.

Not sure if this is helpful or correct. Let me know if I can provide additional information.

Thanks!
Connor

@cwpenhale
Copy link

Also, I'm getting stuck on the deploy for the loadbalancer resource; any advice?

Resource Create Failed: Resources.Pool Members: Resources.Loadbalancer.Property Error: Resources[0].Properties: Property Master Count Not Assigned

@bartpved
Copy link
Author

@cwpenhale adding missing params is OK. About the HEAT error, looks like the param master_count is not passed properly, you will need to pass it if it's missing.

@ioggstream
Copy link
Contributor

To me it worked nicely. I just modified:

  • the LB to point to the fixed_network avoiding to passing twice thru the external_network
  • removed from openshift.yaml all lbaasv1 staff which was now not useful
  • moved all templates to newton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants