Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bmh firmware options #300

Conversation

josecastillolema
Copy link

@josecastillolema josecastillolema commented Feb 15, 2024

Description

Allows to change some BIOS settings through the BareMetalHost definition.

Some context: Enable reproducible data plane testing in the scale/alias lab

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Testing

Do not merge yet, if everyone agrees on the approach let's take the PR for a ride in the ScaleLab.

Signed-off-by: Jose Castillo Lema <[email protected]>
Copy link

@mukrishn mukrishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Jose Castillo Lema <[email protected]>
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants