upstream rebase and fixed hostname issue

.ansible-lint

@@ -8,10 +8,13 @@ skip_list:
   - '601'
   - '602'
   - '701'
+  - ignore-errors
+  - var-naming
   #(dblack) AFAICT the ansible linter only works with a prebuilt containr w/ latest
   #ansible core, which does not include the ipmi or openssh modules that are used
   #in the playbooks below. So excluding them here is a hack to work around the
   #linter error.
 exclude_paths:
   - ansible-ipi-install/roles/prepare-kni/tasks/main.yml
   - ansible-ipi-install/roles/scale-node-prep/tasks/main.yml
+

.github/workflows/ansible-lint.yml

@@ -1,17 +1,35 @@
-name: Ansible Lint # feel free to pick your own name
-on: [push, pull_request]
+---
+name: Ansible Lint  # feel free to pick your own name
+
+on: pull_request
 
 jobs:
   build:
     runs-on: ubuntu-latest
 
     steps:
       # Important: This sets up your GITHUB_WORKSPACE environment variable
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v3.5.3
 
-      - name: Run ansible-lint
-        # replace `main` with any valid ref, or tags like `v6`
-        uses: ansible-community/ansible-lint-action@v6
-        # optional:
+      - uses: actions/[email protected]
         with:
-          path: "ansible-ipi-install/"  # <-- only one value is allowed
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/*requirements.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
+
+      - uses: actions/[email protected]
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install flake8 pytest
+          if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+          if [ -f test-requirements.txt ]; then pip install -r test-requirements.txt; fi
+          ansible-galaxy collection install -r ansible-ipi-install/requirements.yml
+
+      - name: Lint Ansible Playbook
+        run: |
+          ansible-lint -p --force-color -c .ansible-lint ansible-ipi-install/playbook.yml
+
+...

.github/workflows/broken-link-check.yml

@@ -1,3 +1,5 @@
+---
+
 on:
   schedule:
     - cron: "0 0 * * *" # daily
@@ -14,3 +16,6 @@ jobs:
     steps:
       - name: Broken Link Check
         uses: technote-space/[email protected]
+
+...
+

.github/workflows/jekyll.yml

@@ -1,27 +1,31 @@
+---
+
 name: Deploy via Jekyll on GitHub  pages
 
 on:
   push:
     branches:
       - master
   schedule:
-    - cron:  '0 0 * * *'
+    - cron: '0 0 * * *'
 
 jobs:
   jekyll:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+      - uses: actions/[email protected]
+
+      # Use GitHub Actions' cache to shorten build times and decrease load on servers
+      - uses: actions/[email protected]
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
 
-    # Use GitHub Actions' cache to shorten build times and decrease load on servers
-    - uses: actions/[email protected]
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-gems-
+      - uses: iranzo/gh-pages-jekyll-action@1
+        env:
+          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+          SOURCE_FOLDER: website
 
-    - uses: iranzo/[email protected]
-      env:
-        GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
-        SOURCE_FOLDER: website
+...

.github/workflows/stale.yml

@@ -1,20 +1,25 @@
+---
+
 name: "Close stale issues"
 on:
   schedule:
-  - cron: "0 0 * * *"
+    - cron: "0 0 * * *"
 
 jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/stale@v5
-      with:
-        repo-token: ${{ secrets.GITHUB_TOKEN }}
-        stale-issue-message: 'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days'
-        days-before-stale: 90
-        days-before-close: 30
-        stale-pr-message: 'This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days'
-        stale-issue-label: 'no-issue-activity'
-        exempt-issue-labels: 'awaiting-approval,work-in-progress'
-        stale-pr-label: 'no-pr-activity'
-        exempt-pr-labels: 'awaiting-approval,work-in-progress'
+      - uses: actions/stale@v8
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          stale-issue-message: 'This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days'
+          days-before-stale: 90
+          days-before-close: 30
+          stale-pr-message: 'This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days'
+          stale-issue-label: 'no-issue-activity'
+          exempt-issue-labels: 'awaiting-approval,work-in-progress'
+          stale-pr-label: 'no-pr-activity'
+          exempt-pr-labels: 'awaiting-approval,work-in-progress'
+
+...
+

.gitmodules

@@ -1,4 +0,0 @@
-[submodule "ansible-ipi-install/collections/ansible_collections/containers/podman"]
-	path = ansible-ipi-install/collections/ansible_collections/containers/podman
-	url = https://github.com/containers/ansible-podman-collections.git
-	shallow = true

OWNERS

@@ -2,12 +2,11 @@
 filters:
   ".*":
     reviewers:
-      - directedsoul1
-      - iranzo
+      - derekhiggins
     approvers:
+      - derekhiggins
       - rlopez133
       - iranzo
-      - directedsoul1
 
   "^documentation/.*":
     labels:

OWNERS_ALIASES

@@ -2,13 +2,14 @@
 
 aliases:
   approvers:
+    - derekhiggins
     - karmab
     - davidvossel
     - rlopez133
     - iranzo
   code-reviewers:
+    - derekhiggins
     - karmab
-    - e-minguez
     - davidvossel
     - rlopez133
     - abays
@@ -25,6 +26,9 @@ aliases:
     - simon3z
     - SchSeba
     - fedepaol
+    - Tal-or
+    - marioferh
+    - jlojosnegros
   cnf-approvers:
     - MarSik
     - simon3z
@@ -33,7 +37,7 @@ aliases:
     - fromanirh
     - cynepco3hahue
   dit-reviewers:
+    - derekhiggins
     - rlopez133
-    - directedsoul1
     - iranzo
     - johnwilkins

README.md

@@ -1,3 +1,6 @@
+# MESSAGE
+This repository is used by limited team who does IPI based installations, for other generic deployment [jetlag](https://github.com/redhat-performance/jetlag) is recommended. 
+
 ## JetSki
 JetSki inherits roles from [upstream](https://github.com/openshift-kni/baremetal-deploy) and aims to provide a consistent, seamless OpenShift installation experience on bare metal in Red Hat's Shared Labs.
 
@@ -20,17 +23,31 @@ _**Table of Contents**_
 
 ## Introduction
 
+For contributions to the ansible-ipi-install roles please visit the [ansible-collection-redhatci-ocp](https://github.com/redhatci/ansible-collection-redhatci-ocp) repository.
+
+## Installation artifacts
+
 This Ansible playbook and set of Ansible roles are aimed at providing a cluster of Red Hat OpenShift 4 (`IPI`) in the Red Hat shared labs with as little user input and intervention as possible.
 
+- [Performance](features/performance/). Performance-related features like Hugepages, real-time kernel, CPU Manager and Topology Manager.
+- [Bonding](features/bonding/). A helper script to create bonding devices with ignition and/or NMstate.
+- [DPDK](features/dpdk/). Example workload that uses DPDK libraries for packet processing.
+- [Kubernetes NMstate](features/kubernetes-nmstate/). Node-networking configuration driven by Kubernetes and executed by NMstate.
+- [Kubernetes NMstate day1](features/kubernetes-nmstate/day1/). Node-networking configuration driven by Kubernetes and executed by NMstate during the deployment of a cluster, by adding settings to install-config.yaml
+- [PTP](features/ptp). This operator manages cluster-wide Precision Time Protocol (PTP) configuration.
+- [SCTP](features/sctp). These assets enable Stream Control Transmission Protocol (SCTP) in the RHCOS
+  worker nodes.
+- [SR-IOV](features/sriov). The SR-IOV Network Operator creates and manages the components of the SR-IOV stack.
+- [CNV](features/cnv). Container Native Virtualization is an add-on to OpenShift Container Platform that allows you to run and manage virtual machine workloads alongside container workloads.
 
 ## Prerequisites
-
 The playbook is intended to be run from outside the cluster of machines you wish to deploy on, from a host we will refer to as `jumphost` for the purposes of this discussion. It could even be a user's laptop or some Virtual Machine. The host from which the the playbook is run from (`jumphost`) must satisfy the following requirements
 
 * Ansible >= 2.9
 * Python 3.6+ 
 * Fedora/CentOS/RHEL (preferably Fedora 30+)
 * Passwordless sudo for user running the playbook on the ansible control node (host where the playbooks are being run from), since certain package installs are done
+* Install ansible collection `ansible-galaxy collection install -r requirements.yml` on your local machine
 
 Passwordless sudo can be setup as below:
 ```
@@ -71,7 +88,8 @@ The `ansible-ipi-install`  directory consists of three main sub-directories in a
 
 - `group_vars` - Contains the `all.yml` which holds the bare minimum variables needed for install
 - `inventory` - contains the file `jetski/hosts` that has advanced variables for customized installation
-- `roles` - contains 11 roles: `bootstrap`, `prepare-kni`, `add-provisioner`, `network-discovery`, `set-deployment-facts`, `shared-labs-prep`,`node-prep` `installer`, `scale-bootstrap`, `scale-node-prep` and `scale-worker`. `node-prep` handles all the prerequisites that the provisioner node requires prior to running the installer. The `installer` role handles extracting the installer, setting up the manifests, and running the Red Hat OpenShift installation.
+- `roles` - contains 9 roles: `bootstrap`, `prepare-kni`, `add-provisioner`, `network-discovery`, `set-deployment-facts`, `shared-labs-prep`,`node_prep` `installer`, `scale-bootstrap`, `scale-node-prep` and `scale-worker`. 
+- downloads 2 roles from the collectoins `redhatci.ocp` - `node_prep` and `installer`, `node_prep` handles all the prerequisites that the provisioner node requires prior to running the installer. The `installer` role handles extracting the installer, setting up the manifests, and running the Red Hat OpenShift installation.
 
 The purpose served by each role can be summarized as follows:
 * `bootstrap` - This role does a **lot** of heavy lifting for seamless deployment in the shared labs. On a high level, this role is responsible for installing needed packages on the `jumphost`, obtaining the list of nodes in your lab allocation dynamically, setting some variables required in inventory as ansible facts (like list of master nodes, worker nodes, mgmt interfaces), copying keys of the `jumphost` to the provisioner, rebuilding the provisioner if needed and finally adding the master and worker nodes to the in-memory dynamic inventory of ansible. This role runs on the `jumphost` aka `localhost`.
@@ -80,7 +98,7 @@ The purpose served by each role can be summarized as follows:
 * `network-discovery` - Set several important variables for the inventory including the NICs and MACs to be used for the provisioning and baremetal networks. Some of the MAC details are obtained from an inventory automatically generated on the Lab Wiki which the network-discovery role uses to further set all variables needed for proper networking. This role runs on the provisioner host.
 * `set-deployment-facts` - This role is used to set some of the facts registered on the jumphost on to the provisioner host for use in future roles. This role runs on the provisioner host.
 * `shared-labs-prep` - Creates the BM bridge, powers on nodes, sets boot order etc. This role runs on the provisioner host.
-* `node-prep` - Prepares the provisioner node for the OpenShift Installer by installing needed packages, creating necessary directories etc. This role runs on the provisioner host.
+* `node_prep` - Prepares the provisioner node for the OpenShift Installer by installing needed packages, creating necessary directories etc. This role runs on the provisioner host.
 * `installer` - Actually drives the OpenShift Installer. This role runs on the provisioner host.
 
 Scale Up worker roles
@@ -130,83 +148,9 @@ The tree structure is shown below:
     │   │   └── node_inv.j2
     │   └── vars
     │       └── main.yml
-    ├── installer
-    │   ├── defaults
-    │   │   └── main.yml
-    │   ├── files
-    │   │   ├── customize_filesystem
-    │   │   │   ├── master
-    │   │   │   └── worker -> master
-    │   │   ├── filetranspile-1.1.1.py
-    │   │   └── manifests
-    │   ├── handlers
-    │   │   └── main.yml
-    │   ├── library
-    │   │   └── podman_container.py
-    │   ├── meta
-    │   │   └── main.yml
-    │   ├── tasks
-    │   │   ├── 10_get_oc.yml
-    │   │   ├── 15_disconnected_registry_create.yml
-    │   │   ├── 15_disconnected_registry_existing.yml
-    │   │   ├── 20_extract_installer.yml
-    │   │   ├── 23_rhcos_image_paths.yml
-    │   │   ├── 24_rhcos_image_cache.yml
-    │   │   ├── 25_create-install-config.yml
-    │   │   ├── 30_create_metal3.yml
-    │   │   ├── 40_create_manifest.yml
-    │   │   ├── 50_extramanifests.yml
-    │   │   ├── 55_customize_filesystem.yml
-    │   │   ├── 59_cleanup_bootstrap.yml
-    │   │   ├── 60_deploy_ocp.yml
-    │   │   ├── 70_cleanup_sub_man_registeration.yml
-    │   │   └── main.yml
-    │   ├── templates
-    │   │   ├── chrony.conf.j2
-    │   │   ├── etc-chrony.conf.j2
-    │   │   ├── httpd_conf.j2
-    │   │   ├── install-config-appends.j2
-    │   │   ├── install-config.j2
-    │   │   ├── magic.j2
-    │   │   └── metal3-config.j2
-    │   ├── tests
-    │   │   ├── inventory
-    │   │   └── test.yml
-    │   └── vars
-    │       └── main.yml
     ├── network-discovery
     │   └── tasks
     │       └── main.yml
-    ├── node-prep
-    │   ├── defaults
-    │   │   └── main.yml
-    │   ├── handlers
-    │   │   └── main.yml
-    │   ├── library
-    │   │   └── nmcli.py
-    │   ├── meta
-    │   │   └── main.yml
-    │   ├── tasks
-    │   │   ├── 100_power_off_cluster_servers.yml
-    │   │   ├── 10_validation.yml
-    │   │   ├── 15_validation_disconnected_registry.yml
-    │   │   ├── 20_sub_man_register.yml
-    │   │   ├── 30_req_packages.yml
-    │   │   ├── 40_bridge.yml
-    │   │   ├── 45_networking_facts.yml
-    │   │   ├── 50_modify_sudo_user.yml
-    │   │   ├── 60_enabled_services.yml
-    │   │   ├── 70_enabled_fw_services.yml
-    │   │   ├── 80_libvirt_pool.yml
-    │   │   ├── 90_create_config_install_dirs.yml
-    │   │   └── main.yml
-    │   ├── templates
-    │   │   └── dir.xml.j2
-    │   ├── tests
-    │   │   ├── inventory
-    │   │   └── test.yml
-    │   └── vars
-    │       └── main.yml
     ├── prepare-kni
     │   └── tasks
     │       └── main.yml

ansible-ipi-install/OWNERS

@@ -3,4 +3,5 @@
 reviewers:
   - dit-reviewers
 approvers:
+  - derekhiggins
   - rlopez133