Skip to content

Commit

Permalink
fix: simplify if statements in GHA workflows and in examples
Browse files Browse the repository at this point in the history
follow-up to 723a734

Co-authored-by: Lukáš Zaoral <[email protected]>
  • Loading branch information
jamacku and lzaoral committed May 3, 2024
1 parent 723a734 commit 4d8082b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/differential-shellcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ jobs:
src/**.{zsh,osh}
token: ${{ secrets.GITHUB_TOKEN }}

- if: ${{ always() }}
- if: always()
name: Upload artifact with defects in SARIF format
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: Differential ShellCheck SARIF
path: ${{ steps.ShellCheck.outputs.sarif }}
retention-days: 7

- if: ${{ always() }}
- if: always()
name: Upload artifact with defects in XHTML format
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}

- if: ${{ always() }}
- if: always()
name: Upload artifact with ShellCheck defects in SARIF format
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -332,14 +332,14 @@ Relative path to SARIF file containing detected defects. Example of use:
name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@v5
- if: ${{ always() }}
- if: always()
name: Upload artifact with ShellCheck defects in SARIF format
uses: actions/upload-artifact@v4
with:
name: Differential ShellCheck SARIF
path: ${{ steps.ShellCheck.outputs.sarif }}
- if: ${{ always() }}
- if: always()
name: Upload SARIF to GitHub using github/codeql-action/upload-sarif
uses: github/codeql-action/upload-sarif@v2
with:
Expand All @@ -355,7 +355,7 @@ Relative path to HTML file containing detected defects. Example of use:
name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@v5
- if: ${{ always() }}
- if: always()
name: Upload artifact with ShellCheck defects in HTML format
uses: actions/upload-artifact@v4
with:
Expand Down

0 comments on commit 4d8082b

Please sign in to comment.