Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for DEBUG in grep 🐛 #322

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Drop support for DEBUG in grep 🐛 #322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72928bb
fix: drop support for DEBUG in grep
jamacku Oct 3, 2023
9536bc8
fix: uninitialized variable RUNNER_DEBUG
jamacku Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,22 +132,22 @@ has_shebang () {
local file="$1"

# shell shebangs detection
if head -n1 "${file}" | grep ${RUNNER_DEBUG:+"--quiet"} -E '^\s*((#|!)|(#\s*!)|(!\s*#))\s*(/usr(/local)?)?/bin/(env\s+)?(sh|ash|bash|dash|ksh|bats)\b'; then
if head -n1 "${file}" | grep --quiet -E '^\s*((#|!)|(#\s*!)|(!\s*#))\s*(/usr(/local)?)?/bin/(env\s+)?(sh|ash|bash|dash|ksh|bats)\b'; then
return 0
fi

# ShellCheck shell directive detection
if grep ${RUNNER_DEBUG:+"--quiet"} -E '^\s*#\s*shellcheck\s+shell=(sh|ash|bash|dash|ksh|bats)\s*' "${file}"; then
if grep --quiet -E '^\s*#\s*shellcheck\s+shell=(sh|ash|bash|dash|ksh|bats)\s*' "${file}"; then
return 0
fi

# Emacs mode detection
if grep ${RUNNER_DEBUG:+"--quiet"} -E '^\s*#\s+-\*-\s+(sh|ash|bash|dash|ksh|bats)\s+-\*-\s*' "${file}"; then
if grep --quiet -E '^\s*#\s+-\*-\s+(sh|ash|bash|dash|ksh|bats)\s+-\*-\s*' "${file}"; then
return 0
fi

# Vi and Vim modeline filetype detection
if grep ${RUNNER_DEBUG:+"--quiet"} -E '^\s*#\s+vim?:\s+(set\s+)?(ft|filetype)=(sh|ash|bash|dash|ksh|bats)\s*' "${file}"; then
if grep --quiet -E '^\s*#\s+vim?:\s+(set\s+)?(ft|filetype)=(sh|ash|bash|dash|ksh|bats)\s*' "${file}"; then
return 0
fi

Expand Down Expand Up @@ -292,7 +292,7 @@ execute_shellcheck () {
# Function to check if the action is run in a Debug mode
is_debug () {
local result
result=$(is_true "${RUNNER_DEBUG}")
result=$(is_true "${RUNNER_DEBUG:-0}")

# shellcheck disable=SC2086
# return require numeric value
Expand Down