Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run differential ShellCheck on merge_group #434

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Run differential ShellCheck on merge_group #434

merged 1 commit into from
Jul 31, 2024

Conversation

masaru-iritani
Copy link
Contributor

@masaru-iritani masaru-iritani commented Jul 30, 2024

What

Run differential-shellcheck on a merge_group GitHub event, which will be fired when a change is added to the merge queue.

Why

For #433, we want to know what link_to_results would be for the code scanning result triggered by a merge_group event. We need to try running the workflow on a merge_group event (without #433).

How tested

An equivalent change works in our private repository.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (b8c7b83) to head (9b9b0e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           5        5           
  Lines         315      315           
=======================================
  Hits          270      270           
  Misses         45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@jamacku jamacku added this pull request to the merge queue Jul 31, 2024
Merged via the queue into redhat-plumbers-in-action:main with commit c63d804 Jul 31, 2024
8 of 9 checks passed
@masaru-iritani masaru-iritani deleted the patch-1 branch July 31, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants