Adds micronaut

[lordofthejars]

No description provided.

[kameshsampath]

@lordofthejars - i see that you have combined GraalVM and micronaut together. if you dont mind can you please split them in to two different PRs, that will be easy for managing and reversing.

[lordofthejars]

@kameshsampath Well currently adding Graal is just adding a Docker image that recompiles your jar file to a native file, so there are no big changes at all.

Also micronaut scaffolds the application at once, I mean you don't do anything manually, you just say I want to create a micronaut app with graal and it creates everything (the docker image + the app), so it is really simple. In any case, since now I am going to update the graal version you will get separated, but as I said the only difference between using graal or not is just a docker image.

[kameshsampath]

@lordofthejars thanks for the explanation, thinking why cant we add something like Dockerfile.graal to all the microservices ? In that way I feel we can say to the interested people that graal is for every app irrespective of the framework we use. IMHO in this case since we use only for micronaut I wonder developers will be confused that graal is only for micronaut.

Do I make sense ?

[lordofthejars]

The problem is that graal does not work with everything, just with projects that do not use reflection. Currently micronaut and probably others but not a lot. El dom., 11 nov. 2018 13:51, Kamesh Sampath <[email protected]> escribió:

…

@lordofthejars <https://github.com/lordofthejars> thanks for the explanation, thinking why cant we add something like Dockerfile.graal to all the microservices ? In that way I feel we can say to the interested people that graal is for every app irrespective of the framework we use. IMHO in this case since we use only for micronaut I wonder developers will be confused that graal is only for micronaut. Do I make sense ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABcmYdJazC2UVL-vy9dr_in5rdYiNbjJks5uuB1MgaJpZM4YYBQ1> .

[lordofthejars]

Not working with SB yet and I think that neither vertx works with graal by default. So the change you mention has sense but in "near" future. El dom., 11 nov. 2018 13:57, Alex Soto <[email protected]> escribió:

…

The problem is that graal does not work with everything, just with projects that do not use reflection. Currently micronaut and probably others but not a lot. El dom., 11 nov. 2018 13:51, Kamesh Sampath ***@***.***> escribió: > @lordofthejars <https://github.com/lordofthejars> thanks for the > explanation, thinking why cant we add something like Dockerfile.graal to > all the microservices ? In that way I feel we can say to the interested > people that graal is for every app irrespective of the framework we use. > IMHO in this case since we use only for micronaut I wonder developers will > be confused that graal is only for micronaut. > > Do I make sense ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#160 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABcmYdJazC2UVL-vy9dr_in5rdYiNbjJks5uuB1MgaJpZM4YYBQ1> > . >

[kameshsampath]

The problem is that graal does not work with everything, just with projects
that do not use reflection. Currently micronaut and probably others but not
a lot.

ok. I will merge, can you please update the README with a NOTE/WARNING saying this ?

[lordofthejars]

Yes. El dom., 11 nov. 2018 13:59, Kamesh Sampath <[email protected]> escribió:

…

The problem is that graal does not work with everything, just with projects that do not use reflection. Currently micronaut and probably others but not a lot. ok. I will merge, can you please update the README with a NOTE/WARNING saying this ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABcmYUEiqMwYN4b_VoGR3KtgJkI3-6tqks5uuB9FgaJpZM4YYBQ1> .

[lordofthejars]

@kameshsampath Done, now there is a warning in the docs.

[kameshsampath]

Also since there are lot of common dependencies across the three microservices will not be easy to add parent pom ?

[lordofthejars]

@kameshsampath about parent pom, well it is the same that happens in Spring Boot, Vertx, microprofile which all services share the same dependencies. Since all three services are in different places, I think that adding a parent pom will add some complexity because when you do the maven package you will need to have this parent pom already published (parent pom will be in a common place between all services) so it means adding an extra step on the build. Also, the examples, in general, are really simple so apart from adding an extra step it will be a bit more complex to understand, now as it happens to any other service we have in the tutorial is self packaged.

[lordofthejars]

@kameshsampath yes multistage does not work in Minishift, for this reason, I have added a Dockerfile-openshift. Thanks for the review.