This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
V2 list region by version #593 #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janine Olear <[email protected]>
Signed-off-by: Janine Olear <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 92.04% 92.10% +0.05%
==========================================
Files 9 9
Lines 528 557 +29
Branches 116 126 +10
==========================================
+ Hits 486 513 +27
- Misses 22 23 +1
- Partials 20 21 +1
☔ View full report in Codecov by Sentry. |
major
suggested changes
Jul 26, 2023
| class TransformerV2ListRegionByVersion(Transformer): | ||
| """Generate a list for all available regions for one version.""" | ||
|
|
||
| def run(self, data): |
There was a problem hiding this comment.
Add # noqa: C901 here to silence the complexity linter. It would be good to revisit how we could make this less complex later. 😉
There was a problem hiding this comment.
Ah right, I added it :)
miyunari
force-pushed
the
v2_list_region_#593
branch
from
c24d58f
to
cb6a694
Compare
Signed-off-by: Janine Olear <[email protected]>
miyunari
force-pushed
the
v2_list_region_#593
branch
from
cb6a694
to
5e9d3f1
Compare
major
approved these changes
Jul 26, 2023
|
Yes, alright - I created an issue, so we don't forget about it :) #689 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #593