Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul to github actions workflows #56

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

tylerhutcherson
Copy link
Collaborator

@tylerhutcherson tylerhutcherson commented Jan 27, 2025

The redis-ai-resources project has grown significantly in the last 9 months with new recipes and exampels to help the community and help enable Redis customers.

However, as we've grown, our ability to manage dependencies for notebooks has broken down. Additionally, making them runnable across different environments has been a huge pain.

The solution introduced here fixes this in a few ways:

  1. Separation of testing workflows based on needs: Instead of blindly testing all notebooks on PRs, we updated actions to test only the notebooks with a git diff. This makes the CI much more modular for individual PRs and merges to main.
  2. Nightly runs of ALL notebooks to ensure quality: This additional step ensures we are up to par across all notebooks and that when issues emerge, we will have notifications and alerts to triage and fix the issue.
  3. Self-contained notebooks: instead of relying on a bloated requirements.txt, we expect each notebook to install the necessary python requirements in the first cell.

@tylerhutcherson tylerhutcherson changed the title Overhaul to github actions workflows WIP -- Overhaul to github actions workflows Jan 27, 2025
@tylerhutcherson tylerhutcherson marked this pull request as ready for review January 27, 2025 15:50
@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Jan 28, 2025
@tylerhutcherson tylerhutcherson changed the title WIP -- Overhaul to github actions workflows Overhaul to github actions workflows Jan 28, 2025
@tylerhutcherson tylerhutcherson force-pushed the feat/RAAE-476-improve-actions-workflows branch from 0a7d9ea to 923bcb3 Compare January 28, 2025 15:40
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thanks for taking this on!

# ---------------------------------------------------------
# 1) Gather all notebooks (except skip-list)
# ---------------------------------------------------------
gather_all_notebooks:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@@ -11,17 +11,6 @@ Open a PR with your addition. We expect the following standards:
3. New additions should be added to the bottom of the list (unless otherwise noted).
4. New additions should not contain any profanity or offensive language.

### What it takes to get a Star
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good remove

@tylerhutcherson tylerhutcherson merged commit 52b7af4 into main Jan 28, 2025
19 checks passed
@tylerhutcherson tylerhutcherson deleted the feat/RAAE-476-improve-actions-workflows branch January 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants