ci: add ruby 3.4 to the matrix (#421)

redis-rb · Dec 28, 2024 · c84f6fd · c84f6fd
1 parent 68b5d6d
commit c84f6fd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -27,11 +27,11 @@ jobs:
       max-parallel: 10
       matrix:
         include:
-          - {redis: '7.2', ruby: '3.3'}
-          - {redis: '7.2', ruby: '3.3', compose: compose.ssl.yaml}
-          - {redis: '7.2', ruby: '3.3', driver: 'hiredis'}
-          - {redis: '7.2', ruby: '3.3', driver: 'hiredis', compose: compose.ssl.yaml}
-          - {redis: '7.2', ruby: '3.3', compose: compose.replica.yaml, replica: '2'}
+          - {redis: '7.2', ruby: '3.4'}
+          - {redis: '7.2', ruby: '3.4', compose: compose.ssl.yaml}
+          - {redis: '7.2', ruby: '3.4', driver: 'hiredis'}
+          - {redis: '7.2', ruby: '3.4', driver: 'hiredis', compose: compose.ssl.yaml}
+          - {redis: '7.2', ruby: '3.4', compose: compose.replica.yaml, replica: '2'}
           - {task: test_cluster_down}
           - {task: test_cluster_broken, restart: 'no', startup: '6'}
           - {redis: '8',   ruby: '3.3', compose: compose.valkey.yaml, replica: '2'}
@@ -64,7 +64,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: ${{ matrix.ruby || '3.3' }}
+          ruby-version: ${{ matrix.ruby || '3.4' }}
           bundler-cache: true
       - name: Pull Docker images
         run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
@@ -91,7 +91,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
       - name: Get IP address of host
         run: |
@@ -146,7 +146,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
       - name: Run rubocop
         run: bundle exec rubocop
@@ -166,7 +166,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
       - name: Pull Docker images
         run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
@@ -226,7 +226,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
       - name: Pull Docker images
         run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
@@ -264,7 +264,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
       - name: Pull Docker images
         run: docker compose --progress quiet -f $DOCKER_COMPOSE_FILE pull
@@ -296,7 +296,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
+          ruby-version: '3.4'
           bundler-cache: true
       - name: Print user limits
         run: ulimit -a

diff --git a/test/redis_client/test_cluster_config.rb b/test/redis_client/test_cluster_config.rb
@@ -6,7 +6,8 @@
 class RedisClient
   class TestClusterConfig < TestingWrapper
     def test_inspect
-      want = '#<RedisClient::ClusterConfig [{:host=>"127.0.0.1", :port=>6379}]>'
+      cfg = { host: '127.0.0.1', port: 6379 }
+      want = "#<RedisClient::ClusterConfig [#{cfg}]>"
       got = ::RedisClient::ClusterConfig.new.inspect
       assert_equal(want, got)
     end