Perform cluster bookeeping tasks _before_ determining retry #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just because a block is not going to be retried, does not mean we should not process topology updates & redirections in response to errors, I think.
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/cluster_bookkeeping
branch
from
21f643e to
f92d39d
Compare
supercaracal
approved these changes
Dec 12, 2023
|
Linter error is not related this pull request. We can ignore them at this time. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just because a block is not going to be retried, does not mean we should not process topology updates & redirections in response to errors, I think.
Before this patch is merged:
retry_countremaining,After this patch is merged:
MOVED).retry_countremaining,This is important for cluster transaction support because we will always do user-provided transaction blocks with
retry_count: 0(we don't know if the provided block is safe to call again); but, we need to make sure we still update the topology so that if the user retries themselves, it will actually work.