Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insufficient error handling for cluster down #385

Merged

Conversation

@supercaracal
Copy link
Member Author

  4) Error:
RedisClient::TestCluster::ScaleReadRandomWithPrimary#test_pubsub_with_wrong_command:
RedisClient::Cluster::ErrorCollection: 172.18.0.4:6379: (RedisClient::ReadTimeoutError) Waited 6.1 seconds
    lib/redis_client/cluster/node.rb:270:in `call_multiple_nodes!'
    lib/redis_client/cluster/node.rb:138:in `call_primaries'
    lib/redis_client/cluster/router.rb:255:in `send_wait_command'
    lib/redis_client/cluster/router.rb:41:in `send_command'
    lib/redis_client/cluster.rb:56:in `blocking_call'
    test/redis_client/test_cluster.rb:893:in `block in wait_for_replication'
    test/testing_helper.rb:35:in `swap_timeout'
    test/redis_client/test_cluster.rb:892:in `wait_for_replication'
    test/redis_client/test_cluster.rb:20:in `teardown'

known, flaky in jruby

@supercaracal supercaracal marked this pull request as ready for review September 27, 2024 10:43
@supercaracal supercaracal merged commit c75cca0 into redis-rb:master Sep 27, 2024
31 of 32 checks passed
@supercaracal supercaracal deleted the fix-error-handling-for-cluster-down branch September 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant