RS: Added generate_self_signed_certs.sh options table to create certificates #1961
+12
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate certificates
yoavredis
reviewed
Aug 10, 2025
There was a problem hiding this comment.
@rrelledge adding a table LGTM, but it duplicates most of the content under "Step 1".
So now we have 2 identical "type" tables, 2 identical "Days" descriptions etc., one after the other.
I suggest to adjust "Step 1" to avoid duplications.
@yoavredis Thanks for taking a look at this. I removed the duplicated content from "Step 1". |
yoavredis
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.