Skip to content

add configurable buffer sizes for Redis connections #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2025
Merged

add configurable buffer sizes for Redis connections #3453

merged 4 commits into from
Aug 4, 2025
+298 −5

Conversation

ofekshenawa
Copy link
Collaborator

  • Set default buffer sizes to 0.5MiB (up from 4KB) for better performance
  • Add ReadBufferSize and WriteBufferSize options to all client types

Fixes #3438

@ofekshenawa ofekshenawa marked this pull request as ready for review July 30, 2025 14:08
@ndyakov ndyakov self-requested a review July 30, 2025 14:36
ndyakov
ndyakov reviewed Jul 30, 2025
View reviewed changes
ndyakov
ndyakov reviewed Jul 31, 2025
View reviewed changes
@ofekshenawa ofekshenawa force-pushed the add-configurable-conn-buffer-sizes branch from 3abf4d1 to 49d2a55 Compare August 3, 2025 14:20
@ndyakov ndyakov self-requested a review August 4, 2025 06:16
ndyakov
ndyakov approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ndyakov ndyakov added the feature label Aug 4, 2025
@ndyakov ndyakov merged commit 1eed165 into master Aug 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndyakov ndyakov ndyakov approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make pool.Conn reader/writer buffer size configurable
2 participants
@ofekshenawa @ndyakov