Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format by hbase-formatter #3995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

atakavci
Copy link
Contributor

Formatted with hbase-formatter settings,
format issue keeps showing up with lots of files. i ll try to fix them gradually.

@tishun
Copy link

tishun commented Oct 15, 2024

We may want to apply a method, similar to the one used in Lettuce, that verifies the formatting (as part of the CI pipeline) and allows to format files with a mvn command (e.g. mvn formatter:format)

What do you think @sazzad16 and @atakavci?

@sazzad16
Copy link
Collaborator

We had #2495 and #2494. Could be worth checking.

IMO, we should consider increasing line-width to at least 100 (could be even 120).

@atakavci
Copy link
Contributor Author

agree with automation suggestions. disagree with formatting it all at one shot now.
we should first fix format issues in a planned manner, then add some linter/formatter to pipeline.

IMO, we should consider increasing line-width to at least 100 (could be even 120).

line width is already 100 in hbase-formatter and count me in for something like 120/140 (120 is common i believe)
<setting id="org.eclipse.jdt.core.formatter.lineSplit" value="100"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants