-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HSCAN with NOVALUES argument #2816
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2816 +/- ##
============================================
- Coverage 78.71% 77.68% -1.03%
- Complexity 6786 7225 +439
============================================
Files 508 537 +29
Lines 22765 24462 +1697
Branches 2446 2608 +162
============================================
+ Hits 17919 19004 +1085
- Misses 3717 4250 +533
- Partials 1129 1208 +79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, the functionality is fine. There are some aspects that require further refinement:
- Our lettercasing uses camel-base based on word boundaries. Since
novalues
is a word on its own, method names should behscanNovalues
instead ofhscanNoValues
. We already have some mixture in letter casing. To align with how it should be, please use a lowercasev
as inNovalues
. - Missing
@since
tags. The next release aims towards 7.0, so please add@since 7.0
to all newly introducedpublic
methods. Adding the tag into the template is typically fine. - There are several unrelated changes such as changes to
RedisServerAsyncCommands
that result from committing all generated interfaces. Please remove these changes from the PR to have a focused pull request.
Thanks for the review!
|
Issue redis#2763 HSCAN has a new argument called NOVALUES. The effect is that only the keys in the hash are returned, without associated values.
The code generator is a bit of Pandora's box, which I don't want to open. I ran the generator, reverted all the (quite many) unrelated changes, and kept strictly the changes related to HSCAN NOVALUES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #2763
HSCAN has a new argument called NOVALUES. The effect is that only the keys in the hash are returned, without associated values.
Make sure that: