Skip to content

Commit

Permalink
Add support for JSON.MSET (#2605)
Browse files Browse the repository at this point in the history
* Added MSET command

MSET command added. Requires all keys to have the same JSON Path, which might fit most use cases, but is a limitation.  Optionally we could make the path an array as well to support all use cases.

* change JSON.MSET signature, add to json command object, fix tests

* its `item.value`, not `item.json`..

* Update MSET.ts

Removed unused RedisCommandArguments

---------

Co-authored-by: Leibale Eidelman <[email protected]>
  • Loading branch information
rowantrollope and leibale authored Sep 18, 2023
1 parent 26b9e6d commit 5a10826
Show file tree
Hide file tree
Showing 3 changed files with 66 additions and 0 deletions.
35 changes: 35 additions & 0 deletions packages/json/lib/commands/MSET.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import { strict as assert } from 'assert';
import testUtils, { GLOBAL } from '../test-utils';
import { transformArguments } from './MSET';

describe('MSET', () => {
it('transformArguments', () => {
assert.deepEqual(
transformArguments([{
key: '1',
path: '$',
value: 1
}, {
key: '2',
path: '$',
value: '2'
}]),
['JSON.MSET', '1', '$', '1', '2', '$', '"2"']
);
});

testUtils.testWithClient('client.json.mSet', async client => {
assert.deepEqual(
await client.json.mSet([{
key: '1',
path: '$',
value: 1
}, {
key: '2',
path: '$',
value: '2'
}]),
'OK'
);
}, GLOBAL.SERVERS.OPEN);
});
28 changes: 28 additions & 0 deletions packages/json/lib/commands/MSET.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { RedisJSON, transformRedisJsonArgument } from '.';
import { RedisCommandArgument } from '@redis/client/dist/lib/commands';

export const FIRST_KEY_INDEX = 1;

interface JsonMSetItem {
key: RedisCommandArgument;
path: RedisCommandArgument;
value: RedisJSON;
}

export function transformArguments(items: Array<JsonMSetItem>): Array<string> {

const args = new Array(1 + items.length * 3);
args[0] = 'JSON.MSET';

let argsIndex = 1;
for (let i = 0; i < items.length; i++) {
const item = items[i];
args[argsIndex++] = item.key;
args[argsIndex++] = item.path;
args[argsIndex++] = transformRedisJsonArgument(item.value);
}

return args;
}

export declare function transformReply(): 'OK';
3 changes: 3 additions & 0 deletions packages/json/lib/commands/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import * as DEL from './DEL';
import * as FORGET from './FORGET';
import * as GET from './GET';
import * as MGET from './MGET';
import * as MSET from './MSET';
import * as NUMINCRBY from './NUMINCRBY';
import * as NUMMULTBY from './NUMMULTBY';
import * as OBJKEYS from './OBJKEYS';
Expand Down Expand Up @@ -42,6 +43,8 @@ export default {
get: GET,
MGET,
mGet: MGET,
MSET,
mSet: MSET,
NUMINCRBY,
numIncrBy: NUMINCRBY,
NUMMULTBY,
Expand Down

0 comments on commit 5a10826

Please sign in to comment.