Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module commands to be marked as unstable and require clients to opt in #2766

Closed
wants to merge 72 commits into from
Closed

module commands to be marked as unstable and require clients to opt in #2766

wants to merge 72 commits into from

Commits on Jun 3, 2024

  1. HSCAN VALUES support (v5)

    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3892f92 View commit details
    Browse the repository at this point in the history

  2. enable module commands to be marked as unstable and require clients t… 

    …o opt in to that.
    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    54d2c0d View commit details
    Browse the repository at this point in the history

  3. update all search commands to v5 / unstable interface

    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5806f68 View commit details
    Browse the repository at this point in the history

  4. update architecture to how we throw an error.

    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0f2e8d5 View commit details
    Browse the repository at this point in the history

  5. revert changes needed for resp3 erroring with multi, as now handled b… 

    …y attachCommand
    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f8a300f View commit details
    Browse the repository at this point in the history

  6. bring all modules / all commands into v5 

    update unstableResp3Module flag to only commands that have unstable api

add ability to tag commands to ignore user type mapping (as transformReply will convert it to a non typed map type)
	update bloom info commands to work with new non typed map ability

fill in search/time-series commands and tag with unstableResp3Modules flag as appropriate
    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1c77ab0 View commit details
    Browse the repository at this point in the history

  7. leibele's type changing and cleaning up disabling of type mapping

    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f13f47a View commit details
    Browse the repository at this point in the history

  8. move tuples to map to requiring simple string for map key 

    adjust all usages of it to SimpleStringReply
    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5daf11b View commit details
    Browse the repository at this point in the history

  9. missed on removal of unstable flag

    @sjpotter
    sjpotter committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a91dded View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. reove ignoreTypeMapping per offline discussion

    @sjpotter
    sjpotter committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9baec20 View commit details
    Browse the repository at this point in the history

  2. revert 2 buffer/simple string changes from experimentation

    @sjpotter
    sjpotter committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    33adc6f View commit details
    Browse the repository at this point in the history

  3. make resp2/resp3 have same return value

    @sjpotter
    sjpotter committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8e7f11c View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. cleanup

    @leibale
    leibale authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    465911e View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. nit

    @leibale
    leibale authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f08e94f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. address leibele's comments + more time series stuff I found in process

    @sjpotter
    sjpotter committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6e60233 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. more work on review comments

    @sjpotter
    sjpotter committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6c34d6b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. attempt to implement leibele's suggestion to clean up code

    @sjpotter
    sjpotter committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d896b09 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. wip - changes of personal review

    @sjpotter
    sjpotter committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7327f5e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. more cleanup

    @sjpotter
    sjpotter committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    9a85b10 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. add command/command info and xread/xreadgroup to v5 support

    @sjpotter
    sjpotter committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    f555c4d View commit details
    Browse the repository at this point in the history

  2. update tests to actually work right

    @sjpotter
    sjpotter committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    17e4dd5 View commit details
    Browse the repository at this point in the history

  3. hscan values isn't part of 7.4

    @sjpotter
    sjpotter committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    629e790 View commit details
    Browse the repository at this point in the history

  4. add hash field expiration commands ported over from v4

    @sjpotter
    sjpotter committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    418f79e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge remote-tracking branch 'upstream/v5' into v5-search-broken

    @sjpotter
    sjpotter committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9dde283 View commit details
    Browse the repository at this point in the history

  2. revert cluster broadcasting todo

    @sjpotter
    sjpotter committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4dea5cb View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. update test.yaml to have 7.4

    @sjpotter
    sjpotter committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4f74a86 View commit details
    Browse the repository at this point in the history

  2. redo time series commands to work with resp3 correctly

    @sjpotter
    sjpotter committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f0af1eb View commit details
    Browse the repository at this point in the history

  3. unwrap json.type in resp3 from extra array

    @sjpotter
    sjpotter committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4bee30f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. add comment to json.type for what we are doing

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    77592d2 View commit details
    Browse the repository at this point in the history

  2. update time series for resp3 to work consistently

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    60499fc View commit details
    Browse the repository at this point in the history

  3. move bloom* info commands to not error out if map type mapping is used

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2ac0964 View commit details
    Browse the repository at this point in the history

  4. tweak unstable search module flag name + add proper error message

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    aef901e View commit details
    Browse the repository at this point in the history

  5. have topk info retur a DoubleReply in resp3

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    60fd22c View commit details
    Browse the repository at this point in the history

  6. fix xread/xreadgroup for map->array type mapping

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4066097 View commit details
    Browse the repository at this point in the history

  7. handle xread/xreadgroup with typing.

    @sjpotter
    sjpotter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2b2bbb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. redo resp2 "map" types to return Objects to be resp3 default compatible 

    + 'fix' for event 'end' test.
    @sjpotter
    sjpotter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9ac2ee8 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. adding "type mapping" to transformReply 

    enables type mapping of "maps" in resp2 responses that are "fake maps"/mapes in resp3.

also enables user configuration of fake maps in resp3 responses (stream message fields).
    @sjpotter
    sjpotter committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    0337343 View commit details
    Browse the repository at this point in the history

  2. move all 'DoubleReply' in resp2 to new type mapping system 

    + fix things I missed in search
    @sjpotter
    sjpotter committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f3013f1 View commit details
    Browse the repository at this point in the history

  3. fix bug + tests 

    zpopmax (and related) get messed up a by a vsc getter insertion.

memory_stats was teting for strings, but inherent DoubleReply are now returned as numbers by default
    @sjpotter
    sjpotter committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    11bd5d2 View commit details
    Browse the repository at this point in the history

  4. change Buffer('a') to Syumbol() to force TypeError 

    unsure if this is correct, but everything that is type 'object' will be handled by code as is.
    @sjpotter
    sjpotter committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    142dfb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. remove some (unnecessary) jsdoc

    @leibale
    leibale authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d42fd70 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. revert and comment out "connect, ready and end events" test

    @leibale
    leibale authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    78f1de6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. use redis CE docker images for all tests without any rebuilding

    @sjpotter
    sjpotter committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5676a72 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. move info commands to discussed format 

    we will always return a typemapped resp3 format, even in resp2.
we will not massage the field names to remove the spaces.

+ handles type mapping of double in resp2 for the one case.
    @sjpotter
    sjpotter committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e57ca82 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/v5-search-broken' into v5-search… 

    …-broken
    @sjpotter
    sjpotter committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bf8a93c View commit details
    Browse the repository at this point in the history

  3. fix bloom info command update 

    didn't update tests, and got types wrong
    @sjpotter
    sjpotter committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    52bd5c0 View commit details
    Browse the repository at this point in the history

  4. fix cms.info test 

    didn't like the null prototype for deep equal
    @sjpotter
    sjpotter committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3d0485b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. rename unstableResp3SearchModule cofnig + xread/group support

    @sjpotter
    sjpotter committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    9adac9d View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. revert to be v4 compat for xread/xreadgroup

    @sjpotter
    sjpotter committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    ea51f39 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. make versions only use latest release

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5202955 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v5-search-broken' into change-testing

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b4b67f6 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from sjpotter/change-testing 

    Change testing
    @sjpotter
    sjpotter authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    58f88b5 View commit details
    Browse the repository at this point in the history

  4. run tests against PRs against v5 branch

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8ad4171 View commit details
    Browse the repository at this point in the history

  5. fixups for testing 

    1 - use redis-stack only
2 - protect hscan-novalues for older versions
3 - disable graph tests
    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d0396e7 View commit details
    Browse the repository at this point in the history

  6. fix running docker with redis-stack

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    faa67f3 View commit details
    Browse the repository at this point in the history

  7. attempt at fixing 1 github test issue

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    830d5db View commit details
    Browse the repository at this point in the history

  8. fix hello test

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fcdb1c0 View commit details
    Browse the repository at this point in the history

  9. fix TS.M[REV]RANGE[_WITHLABELS|_SELECTED_LABELS] & `TS.MGET[_WITHLA… 

    …BELS|_SELECTED_LABELS]`
    @leibale
    leibale committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7ead8e4 View commit details
    Browse the repository at this point in the history

  10. fix time series

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    68ca83b View commit details
    Browse the repository at this point in the history

  11. fix non profile search commands

    @sjpotter
    sjpotter committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9e8c183 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. attempt to make ts info / info debug backwards cmmpatable

    @sjpotter
    sjpotter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3f65936 View commit details
    Browse the repository at this point in the history

  2. update to handle 'warning' in profile data return

    @sjpotter
    sjpotter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    839e14b View commit details
    Browse the repository at this point in the history

  3. attempt to make test more reliable

    @sjpotter
    sjpotter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    91ed69e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. fix hello test to test if modules is an array

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2d18b36 View commit details
    Browse the repository at this point in the history

  2. clean up rejection fix for clientkill

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    31d61b8 View commit details
    Browse the repository at this point in the history

  3. fix ts.info/debug again to hopefully be cleaner

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    25fdd32 View commit details
    Browse the repository at this point in the history

  4. small cleanups

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    59a27cc View commit details
    Browse the repository at this point in the history

  5. more cleanup

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bf11c35 View commit details
    Browse the repository at this point in the history

  6. transformTuplesReply can be a BlobStringReply or SimpleStringReply

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1a5ac15 View commit details
    Browse the repository at this point in the history

  7. update ft.info to actually work + with newest options

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    16950d0 View commit details
    Browse the repository at this point in the history

  8. small tweak for stopWords

    @sjpotter
    sjpotter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e1b935c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge remote-tracking branch 'upstream/v5' into v5-search-broken

    @sjpotter
    sjpotter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1f346f8 View commit details
    Browse the repository at this point in the history