feat: add numeric array membership methods to NumericField (#400) #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add containsDouble(), containsLong(), and containsInt() methods to NumericField class to enable array membership queries similar to TagField.in() functionality. These methods allow users to query for entities where numeric array fields contain any of the specified values using EntityStream. Resolves redis#400 network restrictions when downloading HuggingFace models. Since our test for issue redis#400 does not require AI functionality, we disable it to prevent the ApplicationContext initialization failure.
Enhanced the AIRedisConfiguration to properly handle HuggingFace tokenizer initialization in CI/offline environments by: 1. Bundling the tokenizer.json file for msmarco-distilbert-dot-v5 in resources 2. Implementing fallback logic to try local resources first, then remote download 3. Improving error handling and logging for tokenizer initialization 4. Removing test-specific CI workarounds in favor of comprehensive solution This addresses the root cause of CI test failures where network restrictions prevent HuggingFace tokenizer downloads, ensuring all tests can run reliably in both local and CI environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add containsDouble(), containsLong(), and containsInt() methods to NumericField class to enable array membership queries similar to TagField.in() functionality. These methods allow users to query for entities where numeric array fields contain any of the specified values using EntityStream.
Resolves #400