Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore a coverage warning re: sysmon on Pythons < 3.12 #3334

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

kurtmckee
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Coverage currently emits a warning in CI when running on Pythons < 3.12 because COVERAGE_CORE=sysmon regardless of Python version. Recent example on Python 3.8:

../../../../../opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/coverage/collector.py:156
  /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/coverage/collector.py:156: CoverageWarning: sys.monitoring isn't available, using default core (no-sysmon)
    self.warn("sys.monitoring isn't available, using default core", slug="no-sysmon")

This PR configures pytest to ignore the warning.

@kurtmckee kurtmckee force-pushed the ignore-coverage-sysmon-warning branch from b156dfb to 961f0f0 Compare July 23, 2024 12:53
@kurtmckee kurtmckee force-pushed the ignore-coverage-sysmon-warning branch from d6d6692 to 766a35c Compare July 31, 2024 12:18
@kurtmckee
Copy link
Contributor Author

Rebased on the master branch

@kurtmckee
Copy link
Contributor Author

Hello @gerzse and @vladvildanov! Please review this PR when you can. It's part of my effort to get CI tests to pass cleanly.

@vladvildanov vladvildanov merged commit c6faa65 into redis:master Sep 2, 2024
56 checks passed
@kurtmckee kurtmckee deleted the ignore-coverage-sysmon-warning branch September 2, 2024 12:41
vladvildanov added a commit that referenced this pull request Sep 27, 2024
vladvildanov added a commit that referenced this pull request Sep 27, 2024
vladvildanov added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants