Improvement: Use shutdown()
Before close()
in connection.py
#3567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
This PR improves socket resource management by implementing the recommended shutdown-then-close pattern in error handling scenarios.
Benefits
Technical Details
The Python documentation explicitly states:
This change introduces properly exception-handled shutdown() calls before close() to ensure sockets are gracefully terminated, even when exceptions occur.
Impact
This is a low-risk change that improves resource cleanup and robustness. The modification is minimal but aligns the codebase with networking best practices, ensuring better socket lifecycle management.