Support Go 1.23 iterators for the ZADD command #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingdaoy
changed the title
rueian
reviewed
Oct 25, 2024
internal/cmds/iter.go
Outdated
| @@ -24,3 +27,10 @@ func (c XaddFieldValue) FieldValueIter(seq iter.Seq2[string, string]) XaddFieldV | |||
| } | |||
| return c | |||
| } | |||
|
|
|||
| func (c ZaddScoreMember) ScoreMemberIter(seq iter.Seq2[float64, string]) ZaddScoreMember { | |||
There was a problem hiding this comment.
Suggested change
| func (c ZaddScoreMember) ScoreMemberIter(seq iter.Seq2[float64, string]) ZaddScoreMember { | |
| func (c ZaddScoreMember) ScoreMemberIter(seq iter.Seq2[string, float64]) ZaddScoreMember { |
Using [string, float64] will be much more convenient for users because the first value usually refers to a unique key.
And Redis sorted set allows elements with the same score, so we better put float64 at the second value.
internal/cmds/iter.go
Outdated
|
|
||
| func (c ZaddScoreMember) ScoreMemberIter(seq iter.Seq2[float64, string]) ZaddScoreMember { | ||
| for score, member := range seq { | ||
| c.cs.s = append(c.cs.s, fmt.Sprintf("%f", score), member) |
There was a problem hiding this comment.
Suggested change
| c.cs.s = append(c.cs.s, fmt.Sprintf("%f", score), member) | |
| c.cs.s = append(c.cs.s, strconv.FormatFloat(score, 'f', -1, 64), member) |
strconv.FormatFloat is much more performant than fmt.Sprintf
|
Just updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#644