feat: improve handling of LOADING response #657
Conversation
|
Hi @rueian, making some progress here and wanted to confirm that I'm heading in the right direction. I noticed that Ping wasn't marked as read-only. Is there a specific reason for this, or might it just be an oversight? I’ll wait for your feedback on this before continuing with the cluster client. |
|
Hi @nesty92, I think we are on the right track, but I am concerned about marking PING as readonly. It is also not marked as readonly in the source https://github.com/redis/redis/blob/unstable/src/commands/ping.json. Can we at least do that in a separate PR? |
|
I agree with your concern about marking PING as readonly. I will handle this in a separate PR to keep the changes isolated and easier to review. |
|
@rueian, I raised this question to get feedback from the Redis team regarding why the PING command is not marked as readonly |
nesty92
force-pushed
the
feature/handle_loading_response
branch
from
0d2c239
to
f69df5d
Compare
|
Hi @rueian, I removed the changes for making |
These changes make the client more resilient during Redis node restarts and initial data loading phases by properly handling LOADING errors that occur when a Redis node is loading data from persistence. Signed-off-by: Ernesto Alejandro Santana Hidalgo <[email protected]>
nesty92
force-pushed
the
feature/handle_loading_response
branch
from
f69df5d
to
320021a
Compare
When a Redis node is loading data (e.g. after restart), it responds with LOADING errors. This makes the client more resilient during Redis node restarts and initial data loading phases.
Close: #656