Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rueidislock CSC re-register #669

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Rueidislock CSC re-register #669

merged 2 commits into from
Nov 13, 2024

Conversation

rueian
Copy link
Collaborator

@rueian rueian commented Nov 12, 2024 •
edited
Loading

  1. Previously when we consumed CSC notifications from the watched locks, we might skip the registration because the internal gate was still hold. This PR doesn't skip the registration anymore.
  2. We respect the custom deadline passed in the context if it is shorter than key validity.

@rueian rueian changed the title Rueidislock re register Rueidislock CSC re-register Nov 12, 2024
@rueian rueian mentioned this pull request Nov 12, 2024
Open
@rueian rueian marked this pull request as ready for review November 12, 2024 08:47
@rueian rueian force-pushed the rueidislock-re-register branch 2 times, most recently from c2188f0 to 7e33b9f Compare November 13, 2024 05:49
@rueian rueian merged commit 57ef0cb into main Nov 13, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rueian