Skip to content

Fix #395: cache is error-aware #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Tokarak
Copy link
Contributor

@Tokarak Tokarak commented Mar 18, 2025

  • Use from_static instead of from_string
  • On error, fallback to cache; Use hyper::Error
  • Same fix for another function

Fixes: #395, but it's very difficult to replicate the conditions which triggered the bug described there.

@Tokarak
Copy link
Contributor Author

Tokarak commented Mar 20, 2025

By The Way that ugly unwrap can be fixed using .map_err for now. I decided to go all the way and try to migrate to axum 👀. That pr will have a fix for this issue, but I Can’t Be Asked to rebase Right Now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Panic and fail ungracefully when internet down
1 participant