Fix element margins inside posts and comments #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements and others not having any margins at all
…messing with formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was inconsistent margins between different types of elements, and headings had no margins at all. This fixes that.
It also removes odd paragraphs that only had a zero width space inside of them that could add large gaps between items. Not really sure if these are user placed or not, but somehow Reddit is able to have the margins on these not interrupt their formatting so I figured it's best to remove them. The code for this is just inside of
rewrite_urls()because I couldn't find a better spot for it but that definitely doesn't fit the name of the function so suggestions on a better place are certainly welcome.Screenshots below from: /r/linux/comments/1k2ilrt/configuring_persistent_network_routing_and/
Before:
After:
