Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYOVPC for AWS #12

Merged
merged 29 commits into from
Dec 2, 2024
Merged

BYOVPC for AWS #12

merged 29 commits into from
Dec 2, 2024

Conversation

micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Aug 1, 2024 •
edited
Loading

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2359
Review deadline: Aug 6

Status: This is in private beta.

Because Cloud docs moved into a separate repo, I had to move redpanda-data/docs#550 into this new PR.

This also nests AWS, Azure, and GCP folders under Create BYOC in the side nav (+ adds aliases and updates links to the new file locations).

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner August 1, 2024 21:15
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 1b2e8b7
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/673e1ef1af4e7e0008fe99ef
😎 Deploy Preview https://deploy-preview-12--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@micheleRP micheleRP mentioned this pull request Aug 1, 2024
Closed
4 tasks
@micheleRP
Copy link
Contributor Author

Status 8/24/24: This should stay in private beta until we get feedback from another customer, per Praseed.

Feediver1
Feediver1 reviewed Oct 1, 2024
View reviewed changes
modules/get-started/pages/cluster-types/byoc/AWS/vpc-byo-aws.adoc Outdated
== Limitations

* You cannot move existing clusters to a customer-managed VPC.
* You cannot change to a different VPC after creating a cluster with a customer-managed VPC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this mean you can have one and only one customer-managed VPC amongst multiple clusters?

Feediver1
Feediver1 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments/suggestions

micheleRP and others added 9 commits October 23, 2024 15:52
@micheleRP
nest AWS, Azure, GCP folders under create BYOC
fcebf9c 
also add aliases & update links to new locations
@micheleRP @Feediver1
Update modules/get-started/pages/cluster-types/byoc/AWS/vpc-byo-aws.adoc
5bfe1ac 
Co-authored-by: Joyce Fee <[email protected]>
@micheleRP @Feediver1
Update modules/get-started/pages/cluster-types/byoc/AWS/vpc-byo-aws.adoc
292842a 
Co-authored-by: Joyce Fee <[email protected]>
@micheleRP @Feediver1
Update modules/get-started/pages/cluster-types/byoc/AWS/vpc-byo-aws.adoc
12a1240 
Co-authored-by: Joyce Fee <[email protected]>
@micheleRP
add glossterm
1bed67f
@micheleRP
incorporate feedback from doc review
013bba2
@micheleRP
build with fixed glossterm
147bc94
@frenchfrywpepper @micheleRP
Updates to public API call
996bc56 
1. Remove redpanda_cloud_storage_manager_policy it is no longer used
2. Add "arn" prefix to connectors_node_group_instance_profile
3. Add permissions boundary field
@micheleRP
incorporate feedback from Praseed + lowercase folders (in URL)
7ca4ce7
@Deflaimun Deflaimun changed the base branch from main to structural-changes October 24, 2024 16:27
Base automatically changed from structural-changes to main October 24, 2024 16:38
Deflaimun and others added 5 commits October 24, 2024 13:42
@Deflaimun
force folder rename
20535b5
@Deflaimun
Merge branch 'main' into 550-byovpc-for-AWS
36137a3 
# Conflicts:
#	modules/ROOT/nav.adoc
#	modules/get-started/pages/cluster-types/byoc/aws-1/create-byoc-cluster-aws.adoc
#	modules/get-started/pages/cluster-types/byoc/aws/create-byoc-cluster-aws.adoc
#	modules/get-started/pages/cluster-types/byoc/azure-1/create-byoc-cluster-azure.adoc
#	modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc
#	modules/get-started/pages/cluster-types/byoc/create-byoc-cluster-aws.adoc
#	modules/get-started/pages/cluster-types/byoc/create-byoc-cluster-azure.adoc
#	modules/get-started/pages/cluster-types/byoc/create-byoc-cluster-gcp.adoc
#	modules/get-started/pages/cluster-types/byoc/gcp-1/create-byoc-cluster-gcp.adoc
#	modules/get-started/pages/cluster-types/byoc/gcp-1/vpc-byo-gcp.adoc
#	modules/get-started/pages/cluster-types/byoc/gcp/create-byoc-cluster-gcp.adoc
#	modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
#	modules/get-started/pages/cluster-types/byoc/vpc-byo-gcp.adoc
@Deflaimun
remove extra folders
cd5cf03
@Deflaimun
re add vpc byo
3b3e8ad
@micheleRP
Merge branch 'main' into 550-byovpc-for-AWS
b732050 
# Conflicts:
#	modules/get-started/pages/cluster-types/byoc/aws/create-byoc-cluster-aws.adoc
#	modules/get-started/pages/whats-new-cloud.adoc
frenchfrywpepper
frenchfrywpepper reviewed Nov 18, 2024
View reviewed changes
modules/get-started/pages/cluster-types/byoc/aws/vpc-byo-aws.adoc

include::shared:partial$feature-flag.adoc[]

With a standard BYOC cluster, Redpanda manages the VPC lifecycle. For additional security, you can deploy the Redpanda glossterm:data plane[] into your existing shared VPC and manage the VPC lifecycle yourself. When you create a BYOC cluster, you specify your VPC and service account. The Redpanda Cloud agent doesn't create any new resources or alter any settings in your account. With a *customer-managed* VPC:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Redpanda Cloud agent doesn't create any new resources or alter any settings in your account.

This feels a little off. We will create many resources, but we will not create VPC or network resources.

@micheleRP
add beta tag + minor text edits
3fce009
@micheleRP
Merge branch 'main' into 550-byovpc-for-AWS
f3f5946 
# Conflicts:
#	modules/get-started/pages/cloud-overview.adoc
#	modules/get-started/pages/cluster-types/byoc/gcp/create-byoc-cluster-gcp.adoc
#	modules/get-started/pages/whats-new-cloud.adoc
@micheleRP
edit What's New: BYOC VNet in LA
30887e9
@micheleRP micheleRP requested a review from david-yu November 20, 2024 17:11
@micheleRP
Copy link
Contributor Author

Adding notes from David:

  1. Similar to BYOVPC for Azure, under Create Managed Resources (link), would it be possible to call out the terraform init, terraform plan, and terraform apply commands.
  2. Similar to BYOVNET feedback, we should create an example tfvars.json file here https://github.com/redpanda-data/cloud-examples/tree/main/customer-managed/aws (Change docs to suggest adding customer specific values)

@AmanAsish-Partypresident AmanAsish-Partypresident mentioned this pull request Nov 23, 2024
Closed
@david-yu
Copy link
Contributor

Providing gist here of my working updates to commands in this doc. High level comments.

  1. We should make it very easy to copy and paste commands so little surgery is required to input the right values into json files. Allow users to input values via env variables and re-use them across inputs.
  2. AWS and Azure instructions should be similar in structure. We should also include commands like check cluster status on Azure.
  3. We should also include teardown instructions for both AWS and Azure.

@JakeSCahill
Copy link
Contributor

Providing gist here of my working updates to commands in this doc. High level comments.

  1. We should make it very easy to copy and paste commands so little surgery is required to input the right values into json files. Allow users to input values via env variables and re-use them across inputs.
  2. AWS and Azure instructions should be similar in structure. We should also include commands like check cluster status on Azure.
  3. We should also include teardown instructions for both AWS and Azure.

Going to add this as a follow-up improvement because this one has been open for so long and we need it for the 24.3 announcement tomorrow.

@JakeSCahill JakeSCahill merged commit c65341d into main Dec 2, 2024
5 checks passed
@JakeSCahill JakeSCahill deleted the 550-byovpc-for-AWS branch December 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpraseed bpraseed bpraseed left review comments

@frenchfrywpepper frenchfrywpepper frenchfrywpepper approved these changes

@Feediver1 Feediver1 Feediver1 approved these changes

@david-yu david-yu Awaiting requested review from david-yu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@micheleRP @david-yu @JakeSCahill @frenchfrywpepper @bpraseed @Feediver1 @Deflaimun