-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-486 Azure VPC peering #129
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Joyce Fee <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Azure this looks good. I am not familiar yet with the GCP side so I'll let someone else weigh in on that.
@david-yu Is this on your radar to review? thx |
> az role assignment create \ | ||
–-assignee $spid \ | ||
--role "Network Contributor" | ||
--scope /subscriptions/<subscription-id>/resourceGroups/<resourcegroup-id>/providers/Microsoft.Network/virtualNetworks/<vnet id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an unfortunate line break here in the rendered output. is actually split between this line and the beginning of the next line.
> az role assignment create \ | ||
--assignee $spid \ | ||
--role $rdid \ | ||
--scope /subscriptions/<subscription-id>/resourceGroups/<resourcegroup-id>/providers/Microsoft.Network/virtualNetworks/<vnet id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an unfortunate line break here in the rendered output. is actually split between this line and the beginning of the next line.
|
||
. Open the *Actions* menu and select *Accept Request*. | ||
. In the confirmation dialog box, verify that the requester owner ID corresponds to the Redpanda account, and select *Yes, Accept*. | ||
. In the next confirmation dialog box, select *Modify my route tables now*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any next steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions
Co-authored-by: Joyce Fee <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
> spid=$(az ad sp create –id <application-id> --query "id" -o tsv | ||
> az role assignment create \ | ||
–-assignee $spid \ | ||
--role "Network Contributor" | ||
--scope /subscriptions/<subscription-id>/resourceGroups/<resourcegroup-id>/providers/Microsoft.Network/virtualNetworks/<vnet id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use environment variables here? i.e.
export RP_RESOURCE_GROUP_ID=<Retrieve resource group id from Redpanda Cloud URL>
export AZURE_VNET_ID=<Retrieve Azure VNET Id from Azure VNET UI>
And then use them in the az
command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # modules/get-started/pages/whats-new-cloud.adoc
# Conflicts: # modules/get-started/pages/whats-new-cloud.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you.
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-486
Review deadline: Thursday Nov 21
Page previews
Add a Dedicated VNet Peering
What's New
Checks