Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-486 Azure VPC peering #129

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Conversation

micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Nov 20, 2024

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-486
Review deadline: Thursday Nov 21

Page previews

Add a Dedicated VNet Peering
What's New

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 0ac2074
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/675b44c0d7c83300086b5713
😎 Deploy Preview https://deploy-preview-129--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@micheleRP micheleRP marked this pull request as ready for review November 20, 2024 04:20
@micheleRP micheleRP requested a review from a team as a code owner November 20, 2024 04:20
Copy link
Contributor

@chapmanc chapmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Azure this looks good. I am not familiar yet with the GCP side so I'll let someone else weigh in on that.

@Feediver1
Copy link
Contributor

@david-yu Is this on your radar to review? thx

> az role assignment create \
–-assignee $spid \
--role "Network Contributor"
--scope /subscriptions/<subscription-id>/resourceGroups/<resourcegroup-id>/providers/Microsoft.Network/virtualNetworks/<vnet id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unfortunate line break here in the rendered output. is actually split between this line and the beginning of the next line.

> az role assignment create \
--assignee $spid \
--role $rdid \
--scope /subscriptions/<subscription-id>/resourceGroups/<resourcegroup-id>/providers/Microsoft.Network/virtualNetworks/<vnet id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unfortunate line break here in the rendered output. is actually split between this line and the beginning of the next line.


. Open the *Actions* menu and select *Accept Request*.
. In the confirmation dialog box, verify that the requester owner ID corresponds to the Redpanda account, and select *Yes, Accept*.
. In the next confirmation dialog box, select *Modify my route tables now*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any next steps?

Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor suggestions

Comment on lines 52 to 56
> spid=$(az ad sp create –id <application-id> --query "id" -o tsv
> az role assignment create \
–-assignee $spid \
--role "Network Contributor"
--scope /subscriptions/<subscription-id>/resourceGroups/<resourcegroup-id>/providers/Microsoft.Network/virtualNetworks/<vnet id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use environment variables here? i.e.

export RP_RESOURCE_GROUP_ID=<Retrieve resource group id from Redpanda Cloud URL>
export AZURE_VNET_ID=<Retrieve Azure VNET Id from Azure VNET UI>

And then use them in the az command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Conflicts:
#	modules/get-started/pages/whats-new-cloud.adoc
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you.

@micheleRP micheleRP merged commit a21ca36 into main Dec 13, 2024
5 checks passed
@micheleRP micheleRP deleted the DOC-486-Document-feature-Azure-VPC-Peering branch December 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants