Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-712 Cloud leader pinning #131

Merged

Conversation

micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Nov 20, 2024

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-712
Review deadline: Nov 25

Page previews

What's New in Redpanda Cloud
Leader pinning in Cloud docs
Leader pinning in Self Managed docs

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit a2d8c8c
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/674fa5770d458b0008ac2229
😎 Deploy Preview https://deploy-preview-131--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,3 @@
= Leader Pinning
:page-categories: Clients, Development
include::ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include::ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source]
include::24.3@ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the page lives in the beta version. If you want to pull that content, you need to specify the version otherwise, it defaults to the latest GA which is 24.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then we need to change this back (i.e., remove 24.3) right before merging, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're waiting to merge until GA then yes. this change just fixes the build until GA is released.

@micheleRP micheleRP marked this pull request as ready for review November 21, 2024 18:03
@micheleRP micheleRP requested a review from a team as a code owner November 21, 2024 18:03
@@ -0,0 +1,2 @@
= Leader Pinning
include::24.3@ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micheleRP 1 thing missing here is: "where do I find my rack ids in Redpanda cloud"? IIRC it's in the UI somewhere, but we should check with @towfiqa and cloud docs folks on if there's existing content

Without this you can't really use leader pinning, and in cloud you are not the one to set the rack IDs (though they are set automatically during cloud provisioning).

So this is fairly critical

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattschumpert: Can we say to run rpk cluster info to get rack id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rogger confirmed yes. This is updated in the single-sourced file in docs repo here: redpanda-data/docs#893

@micheleRP micheleRP force-pushed the DOC-712-Document-Cloud-Feature-AZ-region-wise-leader-pinning branch from e3f82d2 to 6471f09 Compare December 4, 2024 00:40
Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@micheleRP micheleRP merged commit 9f3afa1 into main Dec 4, 2024
5 checks passed
@micheleRP micheleRP deleted the DOC-712-Document-Cloud-Feature-AZ-region-wise-leader-pinning branch December 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants