-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-712 Cloud leader pinning #131
DOC-712 Cloud leader pinning #131
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,3 @@ | |||
= Leader Pinning | |||
:page-categories: Clients, Development | |||
include::ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include::ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source] | |
include::24.3@ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the page lives in the beta version. If you want to pull that content, you need to specify the version otherwise, it defaults to the latest GA which is 24.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then we need to change this back (i.e., remove 24.3) right before merging, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're waiting to merge until GA then yes. this change just fixes the build until GA is released.
@@ -0,0 +1,2 @@ | |||
= Leader Pinning | |||
include::24.3@ROOT:develop:produce-data/leader-pinning.adoc[tag=single-source] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@micheleRP 1 thing missing here is: "where do I find my rack ids in Redpanda cloud"? IIRC it's in the UI somewhere, but we should check with @towfiqa and cloud docs folks on if there's existing content
Without this you can't really use leader pinning, and in cloud you are not the one to set the rack IDs (though they are set automatically during cloud provisioning).
So this is fairly critical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattschumpert: Can we say to run rpk cluster info
to get rack id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rogger confirmed yes. This is updated in the single-sourced file in docs repo here: redpanda-data/docs#893
e3f82d2
to
6471f09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-712
Review deadline: Nov 25
Page previews
What's New in Redpanda Cloud
Leader pinning in Cloud docs
Leader pinning in Self Managed docs
Checks