Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: fix load env behavior #1478

Merged
merged 3 commits into from
Oct 17, 2024
Merged

frontend: fix load env behavior #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe3380e
frontend: update rspack to access rawPublicVars
malinskibeniamin Oct 17, 2024
b9070a1
frontend: fix rspack scss warning
malinskibeniamin Oct 17, 2024
c2f5cb2
frontend: use rawPublicVars to mirror CRA env secrets
malinskibeniamin Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/.sample.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,20 @@ NODE_OPTIONS=--openssl-legacy-provider
# forces ui to assume its in dev mode
# - websocket will always connect to "localhost:9090"
# - enables some additional debug logging
REACT_APP_DEV_HINT=true
REACT_APP_DEV_HINT=true # for debugging, since we can't override NODE_ENV

# Don't fail compilation in dev because of eslint
DISABLE_ESLINT_PLUGIN=true

ESLINT_NO_DEV_ERRORS=true

# fake build-info
# REACT_APP_CONSOLE_GIT_SHA=abc123
# REACT_APP_CONSOLE_GIT_REF=dev-local
# REACT_APP_CONSOLE_GIT_REF=dev-local # 'master' or 'v1.2.3'
# REACT_APP_BUILD_TIMESTAMP=32503680000
# REACT_APP_BUILT_FROM_PUSH=false # was built by 'image-on-push'?

# Enable all features while developing locally
REACT_APP_ENABLED_FEATURES=SINGLE_SIGN_ON,REASSIGN_PARTITIONS
REACT_APP_ENABLED_FEATURES=SINGLE_SIGN_ON,REASSIGN_PARTITIONS # for debugging, used to set/override enabled features while developing
Loading
Loading