-
Notifications
You must be signed in to change notification settings - Fork 45
DOC-1378: Compaction robustness #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (2)
modules/reference/pages/properties/cluster-properties.adoc (1)
3698-3698
: Consider linkingsegment.ms
to its property reference
The note "Do not set this value lower thansegment.ms
." is helpful but could be enhanced by adding a cross-reference to thesegment.ms
documentation (xref:reference:properties/cluster-properties.adoc#log_segment_ms).modules/reference/pages/properties/topic-properties.adoc (1)
45-50
: Align alias IDs with existing conventions.The new entries use dots in the alias IDs (
max.compaction.lag.ms
/min.compaction.lag.ms
), while other properties strip dots from IDs. Consider renaming these tomaxcompactionlagms
andmincompactionlagms
for consistency.@@ -45,4 +45,4 @@ -| <<max.compaction.lag.ms,`max.compaction.lag.ms`>> +| <<maxcompactionlagms,`max.compaction.lag.ms`>> @@ -48,4 +48,4 @@ -| <<min.compaction.lag.ms,`min.compaction.lag.ms`>> +| <<mincompactionlagms,`min.compaction.lag.ms`>>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
antora.yml
(1 hunks)local-antora-playbook.yml
(2 hunks)modules/manage/pages/cluster-maintenance/compaction-settings.adoc
(1 hunks)modules/reference/pages/properties/cluster-properties.adoc
(2 hunks)modules/reference/pages/properties/topic-properties.adoc
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (4)
antora.yml (2)
3-3
: Bump Antora version to 25.2
Theversion
attribute has been correctly updated from25.1
to25.2
for this beta release.
4-5
: Add beta display metadata
Includingdisplay_version: '25.2 Beta'
andprerelease: true
properly flags this as a pre-release.local-antora-playbook.yml (2)
3-3
: Verify start_page target
Thestart_page
has been updated to25.2@ROOT:get-started:intro-to-events.adoc
. Please confirm this is the intended landing page for the 25.2 beta docs.
18-18
: Prioritize main branch in sources
Movingmain
to the front of thebranches
list ensures the latest content is served first. This aligns with your version bump.
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-1378
Review deadline:
Page previews
Topic Properties
max_compaction_lag_ms
min_compaction_lag_ms
Checks