Skip to content

DOC-1378: Compaction robustness #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

DOC-1378: Compaction robustness #1153

wants to merge 14 commits into from

Conversation

Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Jun 6, 2025

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-1378
Review deadline:

Page previews

Topic Properties

max_compaction_lag_ms

min_compaction_lag_ms

Checks

  • [ X] New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Feediver1 Feediver1 requested a review from a team as a code owner June 6, 2025 01:11
Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 42d6fc5
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/684c397cebe2ab0008ad66bc
😎 Deploy Preview https://deploy-preview-1153--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Feediver1 Feediver1 requested a review from mattschumpert June 6, 2025 01:18
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
modules/reference/pages/properties/cluster-properties.adoc (1)

3698-3698: Consider linking segment.ms to its property reference
The note "Do not set this value lower than segment.ms." is helpful but could be enhanced by adding a cross-reference to the segment.ms documentation (xref:reference:properties/cluster-properties.adoc#log_segment_ms).

modules/reference/pages/properties/topic-properties.adoc (1)

45-50: Align alias IDs with existing conventions.

The new entries use dots in the alias IDs (max.compaction.lag.ms / min.compaction.lag.ms), while other properties strip dots from IDs. Consider renaming these to maxcompactionlagms and mincompactionlagms for consistency.

@@ -45,4 +45,4 @@
-| <<max.compaction.lag.ms,`max.compaction.lag.ms`>>
+| <<maxcompactionlagms,`max.compaction.lag.ms`>>

@@ -48,4 +48,4 @@
-| <<min.compaction.lag.ms,`min.compaction.lag.ms`>>
+| <<mincompactionlagms,`min.compaction.lag.ms`>>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a60814 and 817207c.

📒 Files selected for processing (5)
  • antora.yml (1 hunks)
  • local-antora-playbook.yml (2 hunks)
  • modules/manage/pages/cluster-maintenance/compaction-settings.adoc (1 hunks)
  • modules/reference/pages/properties/cluster-properties.adoc (2 hunks)
  • modules/reference/pages/properties/topic-properties.adoc (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - redpanda-docs-preview
  • GitHub Check: Header rules - redpanda-docs-preview
  • GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (4)
antora.yml (2)

3-3: Bump Antora version to 25.2
The version attribute has been correctly updated from 25.1 to 25.2 for this beta release.


4-5: Add beta display metadata
Including display_version: '25.2 Beta' and prerelease: true properly flags this as a pre-release.

local-antora-playbook.yml (2)

3-3: Verify start_page target
The start_page has been updated to 25.2@ROOT:get-started:intro-to-events.adoc. Please confirm this is the intended landing page for the 25.2 beta docs.


18-18: Prioritize main branch in sources
Moving main to the front of the branches list ensures the latest content is served first. This aligns with your version bump.

@Feediver1 Feediver1 requested a review from wdberkeley June 12, 2025 18:21
@Feediver1 Feediver1 requested a review from wdberkeley June 13, 2025 14:40
@redpanda-data redpanda-data deleted a comment from coderabbitai bot Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants