Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: add --compression flag to rpk transform deploy #832

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Deflaimun
Copy link
Contributor

@Deflaimun Deflaimun commented Oct 30, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2583
Review deadline: Nov 4th (Monday)

Page previews

https://deploy-preview-832--redpanda-docs-preview.netlify.app/current/reference/rpk/rpk-transform/rpk-transform-deploy/

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Deflaimun Deflaimun requested a review from a team as a code owner October 30, 2024 15:43
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 70d2784
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6722a5d09d80f1000872bc93
😎 Deploy Preview https://deploy-preview-832--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@Deflaimun Deflaimun force-pushed the DOC-369-Docs-update-for-data-transforms-output-batch-compression branch from 4089cf4 to 5f7898c Compare October 30, 2024 20:39
Copy link
Contributor

@kbatuigas kbatuigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One link to check

@@ -76,4 +77,24 @@ Deploy a transformation with multiple environment variables:
rpk transform deploy --var FOO=BAR --var FIZZ=BUZZ
----

Configure compression for batches output by data transforms. The default setting is "no compression," but you can choose from the following options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "no compression" the same as none listed below?


Enabling compression may increase computation costs and could impact latency at the output topic.

For more details, see xref:modules:deploy/deployment-option/self-hosted/manual/sizing.adoc[].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more details, see xref:modules:deploy/deployment-option/self-hosted/manual/sizing.adoc[].
For more details, see xref:deploy:deployment-option/self-hosted/manual/sizing.adoc[].

Please double check - maybe ROOT needs to be added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants