Skip to content

Conversation

Deflaimun
Copy link
Contributor

@Deflaimun Deflaimun commented Oct 30, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2583
Review deadline: Nov 4th (Monday)

Page previews

https://deploy-preview-832--redpanda-docs-preview.netlify.app/current/reference/rpk/rpk-transform/rpk-transform-deploy/

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Deflaimun Deflaimun requested a review from a team as a code owner October 30, 2024 15:43
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit e6af86f
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/674dd5969549c30008543fde
😎 Deploy Preview https://deploy-preview-832--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Deflaimun Deflaimun requested a review from oleiman October 30, 2024 19:10
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@Deflaimun Deflaimun force-pushed the DOC-369-Docs-update-for-data-transforms-output-batch-compression branch from 4089cf4 to 5f7898c Compare October 30, 2024 20:39
@Deflaimun Deflaimun requested a review from kbatuigas October 30, 2024 20:39
Copy link
Contributor

@kbatuigas kbatuigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One link to check

@Feediver1
Copy link
Contributor

@Deflaimun What is the status on this one? Who might answer the question from @kbatuigas ?

@Deflaimun
Copy link
Contributor Author

@Feediver1 just need a confirmation from @oleiman.

@Deflaimun Deflaimun requested a review from kbatuigas December 2, 2024 15:43
@Deflaimun Deflaimun force-pushed the DOC-369-Docs-update-for-data-transforms-output-batch-compression branch from f1f700a to e6af86f Compare December 2, 2024 15:43
@Deflaimun
Copy link
Contributor Author

Ready for review. Confirmed that "no compression" is actually just the "none" value

Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Deflaimun Deflaimun merged commit 4ccf552 into main Dec 4, 2024
7 checks passed
@Deflaimun Deflaimun deleted the DOC-369-Docs-update-for-data-transforms-output-batch-compression branch December 4, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants