Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify cert-manager install with 'kubectl wait', #152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JayKayy
Copy link

@JayKayy JayKayy commented May 30, 2024

Summary

In place of the cm-verifier, we take advantage of the kubectl wait command to wait for the 3 deployments of cert-manager to become available.

This PR does the following:

  • removes the dependency on cert-manager-verifier.
  • simplifies the logic of the install-cert-manager.sh
  • makes install-cert-manager.sh agnostic of OS/architectures, as it just uses kubectl.

Testing

make kind-create
make certmanager-install

Verify that the output looks like this:

...
deployment.apps/cert-manager-webhook created
mutatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook configured
validatingwebhookconfiguration.admissionregistration.k8s.io/cert-manager-webhook configured
deployment.apps/cert-manager-cainjector condition met
deployment.apps/cert-manager-webhook condition met
deployment.apps/cert-manager condition met

-> kubectl get pods -A # verify the pods are in fact up and Running
...
cert-manager         cert-manager-c9d79589f-r7lbg                 1/1     Running   0          10s
cert-manager         cert-manager-cainjector-597db8dbc-f95k8      1/1     Running   0          10s
cert-manager         cert-manager-webhook-cc66556ff-fvsdq         1/1     Running   0          10s

Additional Notes

kubectl wait is in an experimental state,

@CLAassistant
Copy link

CLAassistant commented May 30, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants