operator v1: ignore maint. mode errors if "not found" #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a rare case, which does not happen in the happy path: - A Pod is running with its broker being already decommissioned - A change is pending that requires restart (Condition to roll pod is set on pod) The code will want to enable maint. mode, which fails with 404: node not found - as it's decom'd already. Since this is a requeue/error, the code does not proceed to all the "scale" stuff, that would get rid of the pod. So basically, a pending pod roll can prevent decommission from happening.
birdayz
requested review from
RafalKorepta,
chrisseto and
andrewstucki
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a rare case, which does not happen in the happy path:
The code will want to enable maint. mode, which fails with 404: node not found - as it's decom'd already. Since this is a requeue/error, the code does not proceed to all the "scale" stuff, that would get rid of the pod. So basically, a pending pod roll can prevent decommission from happening.
Since there's no broker hosted on this pod (already decom'd), there's no point in turning on maint. mode, so just skip if not found.