Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rptest: cache metrics test with custom mountpoint #24140

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

rptest: cache metrics test with custom mountpoint #24140

wants to merge 1 commit into from

Conversation

nvartolomei
Copy link
Contributor

Addition for #24138. Review only the last commit please 2cad68c

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@nvartolomei nvartolomei requested a review from a team as a code owner November 15, 2024 16:39
@nvartolomei nvartolomei requested review from gousteris and removed request for a team November 15, 2024 16:39
@nvartolomei nvartolomei mentioned this pull request Nov 15, 2024
Merged
7 tasks
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 15, 2024 •
edited
Loading

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/58117#019330f3-fcb8-4792-8075-9c7488b9c6b0:

"rptest.tests.shadow_indexing_compacted_topic_test.TSWithAlreadyCompactedTopic.test_initial_upload"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/58117#0193310f-0f97-4e79-82df-ccfb435096e6:

"rptest.tests.shadow_indexing_compacted_topic_test.TSWithAlreadyCompactedTopic.test_initial_upload"

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 15, 2024 •
edited
Loading

Retry command for Build#58117

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/shadow_indexing_compacted_topic_test.py::TSWithAlreadyCompactedTopic.test_initial_upload
tests/rptest/tests/full_disk_test.py::FullDiskReclaimTest.test_full_disk_triggers_gc

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 15, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58117#019330f3-fcbc-480e-a1ac-fba3c8b28de5
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58117#0193310f-0f9d-4db8-8978-07541e97eb80

@nvartolomei
Copy link
Contributor Author

@ivotron wdyt?

dotnwat
dotnwat reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it work in CDT where we aren't running in docker? seems like we might need to add a special environment variant of some sort to mock the cache disk size in that case?

@ivotron
Copy link
Member

ivotron commented Nov 21, 2024

+1 on what Noah mentioned. We can launch a /cdt to run affected tests and see how that looks

nvartolomei
nvartolomei commented Nov 22, 2024
View reviewed changes
tests/rptest/tests/node_metrics_test.py
def test_node_cache_storage_metrics(self):
# Skip the test if dedicated nodes are used as we don't have custom
# mount points for cache directories.
if self.redpanda.dedicated_nodes:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnwat @ivotron this handles the "CDT" case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat left review comments

@ivotron ivotron ivotron approved these changes

@gousteris gousteris Awaiting requested review from gousteris gousteris is a code owner automatically assigned from redpanda-data/devprod

@Lazin Lazin Awaiting requested review from Lazin

@andrwng andrwng Awaiting requested review from andrwng

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvartolomei @vbotbuildovich @ivotron @dotnwat