DO NOT MERGE Kafka/data/noticket/rpcs smashup #24150
Draft
+2,451
−910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/build
area/redpanda
area/wasm
oleiman
force-pushed
the
kafka/data/noticket/rpcs-smashup
branch
from
dae90a7
to
d10b534
Compare
and remove janky fwd declaration from audit_log_manager.h
…ring) Probably some of this stuff could/should come OUT into k/d But the issue here is that at some point I decided to plump the k/d/rpc client DOWN into x/rpc/client, which mean I have to have one all set up in order to run these tests. maybe instead of injecting k/d/rpc into x/rpc, could just inject into the transform service alongside the existing one. so test code looks the same, and you don't have this weird cross dependency and so on. Problem with that is that I'd like to migrate all the topic creator actions from x/rpc to k/d way (rather than using topic creator directly) so you'd need a client in there for that. but maybe like an rpc client is sort of the wrong place for those bits to coexist anyway... partition manager is the other thing with a bunch of duplication. would be cool if the xform specific stuff could be a mixin of some sort for the basic one that works on kafka proxies.
Remove duplicated code from x/rpc and fix up tests accordingly. Note that the "client produces records" test is not really relevant here. It is moved to k/d/rpc/test in another commit.
requires a bunch of test fenagling but the partition manager guts diverge. there's this produce path in local_service that's only called through the transform specific client APIs... maybe those can be generalized out in the x::rpc::client, but I figure there's work that wants to be done _after_ the network hop. Or something like that.
oleiman
force-pushed
the
kafka/data/noticket/rpcs-smashup
branch
from
d10b534
to
c84ad42
Compare
oleiman
force-pushed
the
kafka/data/noticket/rpcs-smashup
branch
from
c84ad42
to
40ee469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.
Backports Required
Release Notes