-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v24.3.x] Feature cleanup #24260
Open
vbotbuildovich
wants to merge
15
commits into
redpanda-data:v24.3.x
Choose a base branch
from
vbotbuildovich:backport-pr-24055-v24.3.x-212
base: v24.3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[v24.3.x] Feature cleanup #24260
vbotbuildovich
wants to merge
15
commits into
redpanda-data:v24.3.x
from
vbotbuildovich:backport-pr-24055-v24.3.x-212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's feature::rpc_transport_unknown_errc. On boostrap, when a node doesn't have all RPC services available yet, it may return non-retriable errors on RPC requests. There is already a mechanism thatmakes RPC return a retriable error on unknown method if some services are still yet to start. Unfortunately, this mechanism requires all nodes to support it, so we check for a feature flag before we use it. As a result, non-retriable errors still can sneak through, as checking the feature flag across all nodes takes some time. This is to remove the feature flag check, as current and previous versions definitely support it. (cherry picked from commit 5e3fd9f)
(cherry picked from commit 81f4709)
as it is always on in all suppoted versions now (cherry picked from commit 247ce02)
feature::raft_improved_configuration is always on in all suppoted versions now (cherry picked from commit 1bc4dc7)
as it is always on in all suppoted versions now (cherry picked from commit f8f5691)
(cherry picked from commit 4314c8d)
feature::raftless_node_status is always on in all suppoted versions now (cherry picked from commit 6ab5551)
feature::node_id_assignment is always on in all suppoted versions now (cherry picked from commit 3f27b93)
feature::replication_factor_change is always on in all suppoted versions (cherry picked from commit 77d6b4d)
feature::ephemeral_secrets is always on in all suppoted versions now (cherry picked from commit 748de08)
feature::seeds_driven_bootstrap_capable is always on in all suppoted versions now (cherry picked from commit 2ce51dd)
it is always on in all suppoted versions now (cherry picked from commit 9d0248c)
feature::partition_move_revert_cancel is always on in all suppoted versions now (cherry picked from commit c749379)
it is always on in all suppoted versions now (cherry picked from commit 61cd125)
(cherry picked from commit 40e7af3)
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/58572#019354cb-780c-44ec-a6eb-cd62f84e29d1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24055