Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "datalake: use serde parquet writer as a default" #24272

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Nov 23, 2024

Snowflake requires column stats, which we don't yet have with serde::parquet.

This reverts commit e70ff29.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@andrwng andrwng added this to the v24.3.1-RC8 milestone Nov 23, 2024
@rockwotj
Copy link
Contributor

FYI We didn't backport this, so we can leave on dev if we want...

Snowflake requires column stats, which we don't yet have with
serde::parquet.

This reverts commit e70ff29.
@rockwotj rockwotj force-pushed the datalake-revert-serde-parquet-default branch from e0b0021 to 4ae77c1 Compare November 23, 2024 16:05
@rockwotj rockwotj removed this from the v24.3.1-RC8 milestone Nov 23, 2024
@vbotbuildovich
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants