[v24.3.x] Iceberg topic lifecycle management #24295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5c8bfeb)
GC process after deleting a topic may involve cleanup in several different places. Track this by introducing a "purge domain" and plumbing it through all lifecycle management methods. (cherry picked from commit 64c4341)
(cherry picked from commit af39c6b)
(cherry picked from commit c35d93b)
Previously we used http_impostor which was not providing adequate S3 API - e.g. if the test put some file into "S3", it then couldn't read that file back (the impostor returned 404). (cherry picked from commit 779e77b)
(cherry picked from commit 3a946dc)
(cherry picked from commit 91a2b5c)
(cherry picked from commit e63d1d2)
Only register a topic state in the stm, don't create the table just yet. (cherry picked from commit c2a5252)
As we want to move table creation and schema changes to the coordinator, this functionality is split out to a separate method, and schema_manager::get_registered_ids expects the table to already exist with a correct schema. (cherry picked from commit 4362a2e)
Resolve a type from a schema_identifier, not by parsing a message. (cherry picked from commit 71356e9)
Its job is to resolve the table schema from a schema identifier and ensure that the corresponding table exists and has a compatible schema. (cherry picked from commit 35b0c61)
(cherry picked from commit d70c12c) Conflicts: src/v/datalake/translation/BUILD
Also make coordinator stm transitions more strict: we now require a topic state to add files and don't create one automatically. Also remove table creation from the file commit path (it is expected that the table is created separately first). (cherry picked from commit cfce9c0)
(cherry picked from commit 8539cb5)
(cherry picked from commit 17a83ad)
(cherry picked from commit 167846f)
We have to do it in DatalakeServices to correctly configure redpanda with the preferred catalog. (cherry picked from commit 1e88454)
(cherry picked from commit 123ccdd)
rockwotj
approved these changes
Nov 25, 2024
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24119
Fixes #24294